Screenshots don't show up in DevTools recordings |
|||
Issue descriptionRepro steps: 0) Start chrome with --enable-features=VizDisplayCompositor 1) Go to any website. 2) Open DevTools. 3) Open the performance tab. 4) Check "Screenshots". 5) Click the record button. 6) Stop the recording after a few seconds. Expected behaviour: Screenshots show up in the recording. Actual behaviour: There are no screenshots in the recording.
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b9a9c83190c95c6732ccd52388f1dd6f2272507 commit 1b9a9c83190c95c6732ccd52388f1dd6f2272507 Author: Saman Sami <samans@chromium.org> Date: Wed Feb 21 04:13:28 2018 Use new video capture API for DevTools tracing snapshots Currently snapshots in DevTools traces don't work if the VizDisplayCompositor feature is enabled. This is because the renderer's CompositorFrames go directly to the gpu process and the existing snapshot code is never run. Add a new code path that works with viz by using FrameSinkVideoCapturer. Eventually the old code path will be removed but for now we'll keep it around until we make sure the new code path works as well as the old one. TBR=jam@chromium.org Bug: 810919 Change-Id: Ie52e32aae06e8aed5a5ce570eb5318c3f3d3f793 Reviewed-on: https://chromium-review.googlesource.com/909965 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#538018} [modify] https://crrev.com/1b9a9c83190c95c6732ccd52388f1dd6f2272507/content/browser/BUILD.gn [modify] https://crrev.com/1b9a9c83190c95c6732ccd52388f1dd6f2272507/content/browser/devtools/devtools_frame_trace_recorder.cc [add] https://crrev.com/1b9a9c83190c95c6732ccd52388f1dd6f2272507/content/browser/devtools/devtools_frame_trace_recorder_for_viz.cc [add] https://crrev.com/1b9a9c83190c95c6732ccd52388f1dd6f2272507/content/browser/devtools/devtools_frame_trace_recorder_for_viz.h [add] https://crrev.com/1b9a9c83190c95c6732ccd52388f1dd6f2272507/content/browser/devtools/devtools_traceable_screenshot.cc [add] https://crrev.com/1b9a9c83190c95c6732ccd52388f1dd6f2272507/content/browser/devtools/devtools_traceable_screenshot.h [modify] https://crrev.com/1b9a9c83190c95c6732ccd52388f1dd6f2272507/content/browser/devtools/protocol/tracing_handler.cc [modify] https://crrev.com/1b9a9c83190c95c6732ccd52388f1dd6f2272507/content/browser/devtools/protocol/tracing_handler.h
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f70fcc71fd0b9c01aeea5df1ad644d4b4dc89a9 commit 4f70fcc71fd0b9c01aeea5df1ad644d4b4dc89a9 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Wed Feb 21 12:44:56 2018 [jumbo] fixes after 'Use new video capture API for DevTools tracing snapshots' https://chromium-review.googlesource.com/c/chromium/src/+/909965 added a new header file without header guards, and a constant duplicated in two files, both of which broke jumbo builds. Also, add a missing base/atomicops.h include. TBR=caseq@chromium.org Bug: 810919 Change-Id: I2a2c89dfcec38e6a2e5d0056158eedb9ef834a91 Reviewed-on: https://chromium-review.googlesource.com/928201 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#538073} [modify] https://crrev.com/4f70fcc71fd0b9c01aeea5df1ad644d4b4dc89a9/content/browser/devtools/devtools_frame_trace_recorder.cc [modify] https://crrev.com/4f70fcc71fd0b9c01aeea5df1ad644d4b4dc89a9/content/browser/devtools/devtools_frame_trace_recorder.h [modify] https://crrev.com/4f70fcc71fd0b9c01aeea5df1ad644d4b4dc89a9/content/browser/devtools/devtools_frame_trace_recorder_for_viz.cc [modify] https://crrev.com/4f70fcc71fd0b9c01aeea5df1ad644d4b4dc89a9/content/browser/devtools/devtools_traceable_screenshot.h
,
Feb 27 2018
,
Apr 20 2018
Marking this as fixed. Unifying code paths is tracked in https://bugs.chromium.org/p/chromium/issues/detail?id=813929 |
|||
►
Sign in to add a comment |
|||
Comment 1 by samans@chromium.org
, Feb 9 2018