New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810914 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

[SpawnedTestServer?] Multiple tests in browser_tests timing out flakily on win7_chromium_rel_ng

Project Member Reported by kbr@chromium.org, Feb 9 2018

Issue description

In this tryjob of an unrelated CL:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/100199

the following tests timed out:
PPAPINaClNewlibTest.WebSocket2
DevToolsSanityTest.TestDispatchKeyEventShowsAutoFill
DevToolsSanityTest.TestSettings
DevToolsReattachAfterCrashTest.TestReattachAfterCrashOnNetwork
WorkerDevToolsSanityTest.InspectSharedWorker
IncognitoProfileMainNetworkContext/NetworkContextConfigurationFtpPacBrowserTest.FtpPac/2
SSLUITest.TestWSSInvalidCertAndClose/1
LoadTimingBrowserTest.HTTPS
DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.ApiAuthCodeFetch/1
DevToolsBeforeUnloadTest.TestWorkerWindowClosing
OutOfProcessPPAPITest.WebSocket2


I would have ignored this but see another incidence of it here:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/100211

from this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/900058/1

In this case these tests failed:
SystemNetworkContext/NetworkContextConfigurationFtpPacBrowserTest.FtpPac/2
DevToolsExtensionTest.DevToolsExtensionInDevToolsExtension
SystemNetworkContext/NetworkContextConfigurationFtpPacBrowserTest.FtpPac/1
ComponentCloudPolicyTest.FetchExtensionPolicy
PDFExtensionTest.OpenFromFTP
CrossOriginXHR.ContentScript
DevToolsSanityTest.TestNetworkSize
DeclarativeNetRequestResourceTypeBrowserTest.Test2/0
SubresourceFilterWebSocketBrowserTest.BlockWebSocket/0
WebSocketBrowserConnectToTest.WebSocketBasicAuthInWSURL
DevToolsExperimentalExtensionTest.TestDevToolsExperimentalExtensionAPI
WebSocketBrowserConnectToTest.WebSocketBasicAuthInWSURLBadCreds
DevToolsBeforeUnloadTest.TestDockedDevToolsInspectedBrowserClose
DevToolsExtensionTest.DevToolsExtensionInItself
ExtensionWebRequestApiTest.WebSocketRequest


I'm not sure which component to assign this to or whether this was a known transient failure. Still, it seems to me that someone should look into it.
 

Comment 1 Deleted

Your first list of failures looks wrong - in particular, the two SystemNetworkContext/NetworkContextConfigurationFtpPacBrowserTest.FtpPac tests failed on the second run, but not on the first.

It looks to me like a lot of those tests are using the Python SpawnedTestServer instead of the EmbeddedTestServer.

All FTP tests use it (PDFExtensionTest.OpenFromFTP, SystemNetworkContext/NetworkContextConfigurationFtpPacBrowserTest.FtpPac/*, CrossOriginXHR.ContentScript), ComponentCloudPolicyTest.FetchExtensionPolicy looks to use it, DevToolsSanityTest.TestNetworkSize looks to use it.

Not going to look at the other tests, but given that, in general, most tests are using the embedded test server (Or should be), it seems likely the issue is the Python test server.  Repeatedly running into flake with starting the server is one of the reasons we switched to a C++ test server in most tests.

Comment 3 by kbr@chromium.org, Feb 10 2018

Cc: iannucci@chromium.org
Thanks for triaging mmenke@. Who can own this? Is it straightforward to switch these tests to use the embedded test server rather than the Python based one? I think I've run into this elsewhere while trying to change the virtual Python environment in Issue 804174, so if we could just get rid of the spawned Python server that would be awesome.

Comment 4 by mmenke@chromium.org, Feb 10 2018

Often no, the embedded test server doesn't support FTP, websockets, OCSP - and I believe there are other features as well.  Tests that just need HTTP/HTTPS should pretty much all be using the EmbeddedTestServer already.  Fixing this would be a pretty major undertaking.  A quarter?  Two?  No idea.

We can't really have someone tackle this as a one-off, would need management buy-in.

Comment 5 by st...@chromium.org, Feb 10 2018

Cc: wylieb@chromium.org
These tests seem like low flakiness at 0.1% to 1%.
One interesting observation: in most of the cases these tests are either still FAIL after 3 retries or PASS at 1st retry.

7-day data on only win7_chromium_rel_ng:
https://screenshot.googleplex.com/zfrYNzjJWtO.png
https://screenshot.googleplex.com/9TBKZcQBSpA.png

7-day data on ALL CQ builders:
https://screenshot.googleplex.com/LKLeZf8cFjS.png
https://screenshot.googleplex.com/LF4Qjqj8Bcn.png


Comment 6 by mmenke@chromium.org, Feb 10 2018

Looks like some of the DevToolsExtensionTests subclass a test framework that starts the spawned test server, but don't actually use it (i.e., these are timing out due to running something they don't seem to even use), though a lot of other tests sharing the same framework do use the spawned test server.  Those might be able to be moved off of it.

Wonder if the second failure rate depends on how many tests failed in the first try.  Do we retry tests in parallel or in sequence?  Could imagine if we make certain assumptions about browser test CPU performance, we could not have enough resources to start the python test server in parallel X times at once.

Comment 8 by mmenke@chromium.org, Feb 14 2018

Summary: [SpawnedTestServer?] Multiple tests in browser_tests timing out flakily on win7_chromium_rel_ng (was: Multiple tests in browser_tests timing out flakily on win7_chromium_rel_ng)

Comment 9 by mmenke@chromium.org, Feb 14 2018

Cc: xunji...@chromium.org
Labels: Network-Triaged
Mergedinto: 804174
Status: Duplicate (was: Untriaged)
This is likely a duplicate of issue 804174.  We can reopen it if needed, but don't think we need to investigate further unless it continues to appear.

Sign in to add a comment