"SSLClientCertificateSelectorCocoaTest.WorkaroundCrashySierra" is flaky |
|||||||||
Issue description"SSLClientCertificateSelectorCocoaTest.WorkaroundCrashySierra" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxTU0xDbGllbnRDZXJ0aWZpY2F0ZVNlbGVjdG9yQ29jb2FUZXN0Lldvcmthcm91bmRDcmFzaHlTaWVycmEM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Feb 12 2018
,
Feb 13 2018
Detected 5 new flakes for test/step "SSLClientCertificateSelectorCocoaTest.WorkaroundCrashySierra". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxTU0xDbGllbnRDZXJ0aWZpY2F0ZVNlbGVjdG9yQ29jb2FUZXN0Lldvcmthcm91bmRDcmFzaHlTaWVycmEM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Feb 14 2018
,
Feb 14 2018
Detected 21 new flakes for test/step "SSLClientCertificateSelectorCocoaTest.WorkaroundCrashySierra". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxTU0xDbGllbnRDZXJ0aWZpY2F0ZVNlbGVjdG9yQ29jb2FUZXN0Lldvcmthcm91bmRDcmFzaHlTaWVycmEM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Feb 15 2018
Fairly high ongoing flake count. Will disable the test shortly.
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bed68dfde5b424976f34252ac142a9249291dea3 commit bed68dfde5b424976f34252ac142a9249291dea3 Author: chcunningham <chcunningham@chromium.org> Date: Thu Feb 15 01:32:00 2018 Disable FLAKY test WorkaroundCrashySierra Full test name is SSLClientCertificateSelectorCocoaTest.WorkaroundCrashySierra Test only runs (and flakes) on mac. Bug: 810909 Change-Id: I2dc0c8d347a8292d89df3e5590cfff1db481829a TBR: sdy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/920685 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#536918} [modify] https://crrev.com/bed68dfde5b424976f34252ac142a9249291dea3/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
,
Feb 15 2018
,
Mar 19 2018
,
Aug 14
,
Oct 25
https://chromium-review.googlesource.com/c/chromium/src/+/1287316 renames and reenables the test. Feel free to re-disable it if it's still flaky.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3edfd2d98b22df221e8fb76fe77a536b029719d commit c3edfd2d98b22df221e8fb76fe77a536b029719d Author: Avi Drissman <avi@chromium.org> Date: Thu Oct 25 20:01:03 2018 Port the client cert selector to use MacViews. This also renames the "WorkaroundCrashySierra" test to "WorkaroundTableViewCrash" as it reliably crashes on 10.11 too, and re-enables the test as the crash workaround is changed to be more aggressively applied. (Fingers crossed.) BUG= 895514 , 810909 Change-Id: Ife4529f348d1ed8940c72d392ee207f5e227a3f4 Reviewed-on: https://chromium-review.googlesource.com/c/1287316 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Sidney San MartÃn <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#602834} [modify] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ssl/ssl_client_certificate_selector.h [modify] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/3773b61598fc9e6e3a947ae74cb0cd2f45a6dbfc/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h [delete] https://crrev.com/3773b61598fc9e6e3a947ae74cb0cd2f45a6dbfc/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm [modify] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ui/views/ssl_client_certificate_selector.cc [add] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ui/views/ssl_client_certificate_selector_mac.h [add] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ui/views/ssl_client_certificate_selector_mac.mm [rename] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ui/views/ssl_client_certificate_selector_mac_browsertest.mm [modify] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/test/BUILD.gn [modify] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/testing/buildbot/filters/mac_window_server_killers.browser_tests.filter |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by megjab...@chromium.org
, Feb 9 2018