New issue
Advanced search Search tips

Issue 810907 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocked on:
issue 810913
issue 815287
issue 815288
issue 859268

Blocking:
issue 469376



Sign in to add a comment

Set up an Android CFI bot on chromium.memory

Project Member Reported by p...@chromium.org, Feb 9 2018

Issue description

We need this so that we don't regress CFI-wise on Android.

The configuration would basically be the same as https://ci.chromium.org/buildbot/chromium.clang/ToTAndroidCFI/ except that it would use clang releases instead of clang ToT.
 

Comment 1 by p...@chromium.org, Feb 9 2018

Blockedon: 810913

Comment 2 by p...@chromium.org, Feb 14 2018

Owner: p...@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5021f87f32a1df10a50ec1a204fde39d8161de

commit 6c5021f87f32a1df10a50ec1a204fde39d8161de
Author: Peter Collingbourne <pcc@chromium.org>
Date: Thu Feb 15 03:18:00 2018

testing: Remove test suite exceptions for ToTAndroidCFI.

Before duplicating this bot's configuration to create a new bot,
let's see how many of these exceptions are legitimate.

Bug:  810907 
Change-Id: I87d0607394af6ce9dbdd1932a240bcea7cbc9e1b
Reviewed-on: https://chromium-review.googlesource.com/920321
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536937}
[modify] https://crrev.com/6c5021f87f32a1df10a50ec1a204fde39d8161de/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/6c5021f87f32a1df10a50ec1a204fde39d8161de/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e3a081d7184de28a1bacee2049716c96b25db6d

commit 6e3a081d7184de28a1bacee2049716c96b25db6d
Author: Peter Collingbourne <pcc@chromium.org>
Date: Fri Feb 16 19:54:33 2018

testing: Restore five test suite exceptions for ToTAndroidCFI.

All of these test suites have failing tests on bullhead devices in
non-CFI builds, so we won't be able to turn them on yet.

Bug:  810907 
Change-Id: I8aa8deef10627460e18a12d6ec45c5aa3fade5ef
Reviewed-on: https://chromium-review.googlesource.com/923710
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537391}
[modify] https://crrev.com/6e3a081d7184de28a1bacee2049716c96b25db6d/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/6e3a081d7184de28a1bacee2049716c96b25db6d/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e07e84e80f72cf8379da9290af411f15f8e72ba1

commit e07e84e80f72cf8379da9290af411f15f8e72ba1
Author: Peter Collingbourne <pcc@chromium.org>
Date: Fri Feb 23 20:28:58 2018

Add an Android CFI bot on chromium.memory (src).

This bot has the same configuration as ToTAndroidCFI except that it
uses clang releases instead of clang ToT.

While here, drop an unnecessary test suite exception from the
configuration for ToTAndroidCFI.

Bug:  810907 
Change-Id: I9040dd8ba64b9117fd6c1425ca60b88a6161bc2b
Reviewed-on: https://chromium-review.googlesource.com/924607
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538877}
[modify] https://crrev.com/e07e84e80f72cf8379da9290af411f15f8e72ba1/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/e07e84e80f72cf8379da9290af411f15f8e72ba1/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/e07e84e80f72cf8379da9290af411f15f8e72ba1/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/e07e84e80f72cf8379da9290af411f15f8e72ba1/tools/mb/mb_config.pyl

Comment 7 by p...@chromium.org, Feb 23 2018

Blockedon: 815287

Comment 8 by p...@chromium.org, Feb 23 2018

Blockedon: 815288

Comment 9 by p...@chromium.org, Mar 7 2018

Status: Verified (was: Started)
https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/932bda52328d04e32aa2abdf2cd6cb726cf3fa67

commit 932bda52328d04e32aa2abdf2cd6cb726cf3fa67
Author: Ryan Tseng <hinoka@google.com>
Date: Wed Mar 07 03:52:24 2018

[milo] Update consoles

As per: https://ci.chromium.org/p/infra/builders/luci.infra.ci/luci-check/90

BUG:  810907 , 801780,  815295 , 814935, 746816
Change-Id: I6a47d472ff304b2265971bdbf4431ed31af73d61
Reviewed-on: https://chromium-review.googlesource.com/952366
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541314}
[modify] https://crrev.com/932bda52328d04e32aa2abdf2cd6cb726cf3fa67/infra/config/global/luci-milo.cfg

Blockedon: 859268

Sign in to add a comment