New issue
Advanced search Search tips

Issue 810896 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove FindInPageControllerDelegate

Project Member Reported by kkhorimoto@chromium.org, Feb 9 2018

Issue description

This was only used to ignore scroll events originating from FIP.  The new fullscreen implementation does not need this information, so it is should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c6103ecd1514030cac0f094b10924daef23c41f

commit 3c6103ecd1514030cac0f094b10924daef23c41f
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Sat Feb 10 01:08:09 2018

[iOS] Remove FindInPageControllerDelegate.

This is no longer necessary, as the new fullscreen implementation
already ignored scrolls originating from fullscreen.

Bug:  810896 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6da22780ef46f5866e698e967e6b3c62e4b2148c
Reviewed-on: https://chromium-review.googlesource.com/912428
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535907}
[modify] https://crrev.com/3c6103ecd1514030cac0f094b10924daef23c41f/ios/chrome/browser/find_in_page/find_in_page_controller.h
[modify] https://crrev.com/3c6103ecd1514030cac0f094b10924daef23c41f/ios/chrome/browser/find_in_page/find_in_page_controller.mm
[modify] https://crrev.com/3c6103ecd1514030cac0f094b10924daef23c41f/ios/chrome/browser/find_in_page/find_tab_helper.h
[modify] https://crrev.com/3c6103ecd1514030cac0f094b10924daef23c41f/ios/chrome/browser/find_in_page/find_tab_helper.mm
[modify] https://crrev.com/3c6103ecd1514030cac0f094b10924daef23c41f/ios/chrome/browser/find_in_page/find_tab_helper_unittest.mm
[modify] https://crrev.com/3c6103ecd1514030cac0f094b10924daef23c41f/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/3c6103ecd1514030cac0f094b10924daef23c41f/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/3c6103ecd1514030cac0f094b10924daef23c41f/ios/chrome/browser/tabs/tab_helper_util.mm
[modify] https://crrev.com/3c6103ecd1514030cac0f094b10924daef23c41f/ios/chrome/browser/ui/browser_list/browser_web_state_list_delegate.mm

Status: Fixed (was: Started)

Sign in to add a comment