New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810893 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 800049



Sign in to add a comment

upgrade ncurses for newer screen.xterm-256color term settings

Project Member Reported by vbendeb@chromium.org, Feb 9 2018

Issue description

with the recent desktop os update, a new screen version seems to be generating new screen type strings, wich confuse old tput version present in the chroot.

Inside chroot:

$ tput bold                                                                                                               
tput: unknown terminal "screen.xterm-256color"
$ tput -V                                                                                                                
ncurses 5.9.20110404


outside chroot:

$ tput bold                                                                                                                                $ tput -V                                                                                                                                  
ncurses 6.0.20170715


> screen -v                                                                                                                                
Screen version 4.06.01 (GNU) 10-Jul-17


any chance tput and there rest of chroot binaries are brought to par with the new desktop OS?

 
Cc: vapier@chromium.org
Labels: -Pri-2 Pri-1
Summary: chrome OS chroot does not work with gnu screen version from Rodete (was: tput version inside chrome os chroot is old)
Changed the title to better reflect the situation.

This can be rectified by overwriting TERM value before starting cros_sdk:

TERM=screen cros_sdk




Comment 2 by vapier@chromium.org, Feb 13 2018

Blockedon: 800049
Summary: upgrade ncurses for newer screen.xterm-256color term settings (was: chrome OS chroot does not work with gnu screen version from Rodete)

Comment 3 by vapier@chromium.org, Feb 13 2018

Labels: -Pri-1 Pri-2
Cc: cernekee@chromium.org
Labels: -Pri-2 Pri-1
The  https://chromium-review.googlesource.com/969413  which supposedly fixed this problem in fact did not fix it for chroot, the issue is still there.

When ncruses is emerged inside chroot, the -r99 version of the ebuild is used, not the -r6 modified by the above patch.

ping... any chance of fixing this soon, or maybe providing some insight wrt two different ebuilds for ncurses?

I think I tried `sudo emerge =sys-libs/ncurses-5.9-r6` at one point, don't remember if that's what fixed it or not.

Ideally it would auto-update to r6.  Not sure how to make that happen.
Components: -Infra>Client>ChromeOS OS>Systems
Labels: -Pri-1 Pri-2
Status: Fixed (was: Unconfirmed)
a plain emerge prob won't do it, but build_packages should.  the bots are picking it up fine.

current samus-paladin & samus-release show in their build_image stage:
[binary  N     ] sys-libs/ncurses-5.9-r6:0/5::portage-stable to /mnt/host/source/src/build/images/samus/R68-10633.0.0/rootfs/ USE="minimal static-libs -ada -cxx -debug -doc -gpm -profile -tinfo -trace -unicode" ABI_X86="(64) -32 (-x32)" 0 KiB
[binary  N     ] sys-libs/ncurses-5.9-r99:5::portage-stable to /mnt/host/source/src/build/images/samus/R68-10633.0.0/rootfs/ USE="static-libs -ada -cxx -gpm -tinfo -unicode" ABI_X86="(64) -32 (-x32)" 0 KiB
Vadim needs to emerge it for his chroot... is there a step similar to build_packages that will do it?
why can't you run build_packages?

the chroot versions are irrelevant here
It actually looks that xterm-256color is now handled fine inside chroot, it's screen.xterm-256color which causes problems.

But FWIW I ran 'bulid_packages --board=bob' and did not see ncurses emerged at all, at least it does not show up in /build/bob/tmp/portage/logs.
Owner: vapier@chromium.org
Status: Assigned (was: Fixed)
screen.xterm-256color is what TERM is set to when entering chroot from a screen session on Rodete of Ubuntu 16.04, it messes up many functions inside chroot.


this patch is trying to add another string to the list https://chromium-review.googlesource.com/#/c/chromiumos/overlays/portage-stable/+/1064481 

I still don't understand though how to emerge this for chroot environment, there is another ebuild in the same directory (ncurses-5.9-r99.ebuild) which takes over when 'sudo emerge ncurses' is run.
Labels: -Pri-2 Pri-1
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/cc80592cfeef01af301ebc7e293d18e64777cbcd

commit cc80592cfeef01af301ebc7e293d18e64777cbcd
Author: Vadim Bendebury <vbendeb@chromium.org>
Date: Wed Jul 18 04:53:25 2018

sys-libs/ncurses: add screen.xterm-256colors

TERM is set to screen.xterm-256colors when in Rodete, let's make sure
this terminal type is recognized inside chroot.

BUG=chromium:810893
TEST=none

Change-Id: I70f152294584a658008b00e7618de2a680301014
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1064481
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/cc80592cfeef01af301ebc7e293d18e64777cbcd/sys-libs/ncurses/ncurses-5.9-r7.ebuild

Labels: -Pri-1 Pri-2

Sign in to add a comment