New issue
Advanced search Search tips

Issue 810887 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GN check should identify deps that should be public based on includes

Project Member Reported by brettw@chromium.org, Feb 9 2018

Issue description

Currently a target B can include headers from a dependency C in its own public headers, but not expose this dependency in its public deps.

This is a bug because another target A that depends on B will see C's headers without having a public dependency, and it won't get the include directories and #defines that may be required to compile those headers.

There is a comment at the bottom HeaderChecker::CheckInclude in tools/gn/header_checker.cc with some ideas for detecting this.
 
Cc: mbonadei@chromium.org

Sign in to add a comment