New issue
Advanced search Search tips

Issue 810879 link

Starred by 1 user
Status: Fixed
Owner:
iclell...@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Move feature policy experimental features to web platform experiments

Project Member Reported by iclell...@chromium.org, Feb 9 2018 
This really just applies to unsized-media for now; other experimental features are not implemented.

Vibration is still special enough that it can get its own flag until we decide whether to pursue or abandon that feature.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38cbc746d8cc24396294e35178c6020f661110f5

commit 38cbc746d8cc24396294e35178c6020f661110f5
Author: Ian Clelland <iclelland@chromium.org>
Date: Wed Feb 14 15:21:34 2018

Make featurepolicyexperimentalfeatures part of the experimental web platform features

(Except for vibration; that one still gets its own flag)

Bug:  810879 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I97bdcc651e6c3d99cc0aff279e83080ea153d031
Reviewed-on: https://chromium-review.googlesource.com/912157
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536717}
[modify] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/ec0a8bfd32b9f52c84e894cfa59af769dc3e7dac/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/unsized-image.tentative.https.sub-expected.txt
[delete] https://crrev.com/ec0a8bfd32b9f52c84e894cfa59af769dc3e7dac/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/resources/feature-policy-vibrate-relocate.html
[add] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/resources/feature-policy-vibrate-relocate.html
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/resources/feature-policy-vibrate.html
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/resources/helper.js
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-allowed-by-container-policy-relocate-and-no-reload-expected.txt
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-allowed-by-container-policy-relocate-and-no-reload.html
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-allowed-by-container-policy-relocate-and-reload.html
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-allowed-by-container-policy.html
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-disabled-expected.txt
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-disabled.php
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-enabledforall.php
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-enabledforself-expected.txt
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-enabledforself.php
[delete] https://crrev.com/ec0a8bfd32b9f52c84e894cfa59af769dc3e7dac/third_party/WebKit/LayoutTests/virtual/feature-policy-experimental-features/external/wpt/feature-policy/experimental-features/README.txt
[delete] https://crrev.com/ec0a8bfd32b9f52c84e894cfa59af769dc3e7dac/third_party/WebKit/LayoutTests/virtual/feature-policy-experimental-features/external/wpt/feature-policy/experimental-features/unsized-image.tentative.https.sub-expected.txt
[delete] https://crrev.com/ec0a8bfd32b9f52c84e894cfa59af769dc3e7dac/third_party/WebKit/LayoutTests/virtual/feature-policy-experimental-features/http/tests/feature-policy-experimental-features/README.txt
[delete] https://crrev.com/ec0a8bfd32b9f52c84e894cfa59af769dc3e7dac/third_party/WebKit/LayoutTests/virtual/feature-policy-experimental-features/http/tests/feature-policy-experimental-features/vibrate_in_cross_origin_iframe_blocked-expected.txt
[add] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/virtual/feature-policy-vibrate/http/tests/feature-policy-vibrate/README.txt
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/virtual/feature-policy-vibrate/http/tests/feature-policy-vibrate/vibrate-allowed-by-container-policy-relocate-and-no-reload-expected.txt
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/virtual/feature-policy-vibrate/http/tests/feature-policy-vibrate/vibrate-disabled-expected.txt
[rename] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/LayoutTests/virtual/feature-policy-vibrate/http/tests/feature-policy-vibrate/vibrate-enabledforself-expected.txt
[modify] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/38cbc746d8cc24396294e35178c6020f661110f5/third_party/WebKit/Source/platform/runtime_enabled_features.json5
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91cff7ae101badc7c57f44b5b64dcf06ca214c20

commit 91cff7ae101badc7c57f44b5b64dcf06ca214c20
Author: Ian Clelland <iclelland@chromium.org>
Date: Thu Feb 15 16:51:37 2018

Remove SitePerProcessFeaturePolicyBrowserTest

Since all of the relevant pieces are either stable or part of
experimental-web-platform-features, the special case code for testing
with feature policy enabled is no longer required.

Bug:  810879 
Change-Id: I316918b4d0c672c86ce832160eda2bdc22065b75
Reviewed-on: https://chromium-review.googlesource.com/919397
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537047}
[modify] https://crrev.com/91cff7ae101badc7c57f44b5b64dcf06ca214c20/content/browser/site_per_process_browsertest.cc

Comment 3 by iclell...@chromium.org, Apr 25 2018

Status: Fixed (was: Started)
►

Sign in to add a comment