Check failed on restore minimized settings window after enter-and-leave tablet mode |
||||
Issue descriptionRepro steps: (1) open settings window, and then minimize it (2) enter tablet mode (3) leave tablet mode (4) unminimize settings window On emulator, it has a Check failed crash: https://paste.googleplex.com/5523639084515328. On device, we could not open it (by clicking on the settings icon on shelf, which has running status dot under the icon).
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6f3f2bea1a5b9af6694611cc55c304de265956b commit b6f3f2bea1a5b9af6694611cc55c304de265956b Author: Qiang Xu <warx@google.com> Date: Tue Feb 13 08:08:50 2018 cros: fix cannot minimize window after leaving tablet mode changes: When leaving tablet mode, we will restore old state, which will finally call BaseState::UpdateMinimizedState. If a window is minimized at this time, it will set |aura::client::kPreMinimizedShowStateKey| to minimized show state. It doesn't make sense to set pre-minimized show state to minimized show state, which could leave us in a bad window state. Bug: 783310 , 810857 Test: emulator test and added test coverage Change-Id: I0c084774a838c0c0b9f3b516011ff31679ae770b Reviewed-on: https://chromium-review.googlesource.com/914981 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#536285} [modify] https://crrev.com/b6f3f2bea1a5b9af6694611cc55c304de265956b/ash/wm/base_state.cc [modify] https://crrev.com/b6f3f2bea1a5b9af6694611cc55c304de265956b/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
,
Feb 14 2018
Issue 766789 has been merged into this issue.
,
Feb 14 2018
Note the CL in #2 doesn't fix the bug in #1 (also issue 766789 ) yet. But the repro steps apply to #1.
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8088889998a4cf81163f79faccb72e7e9a39337a commit 8088889998a4cf81163f79faccb72e7e9a39337a Author: Qiang Xu <warx@google.com> Date: Tue Feb 20 21:20:59 2018 m65 merge: cros: fix cannot minimize window after leaving tablet mode changes: When leaving tablet mode, we will restore old state, which will finally call BaseState::UpdateMinimizedState. If a window is minimized at this time, it will set |aura::client::kPreMinimizedShowStateKey| to minimized show state. It doesn't make sense to set pre-minimized show state to minimized show state, which could leave us in a bad window state. TBR=jamescook@chromium.org (cherry picked from commit b6f3f2bea1a5b9af6694611cc55c304de265956b) Bug: 783310 , 810857 Test: emulator test and added test coverage Change-Id: I0c084774a838c0c0b9f3b516011ff31679ae770b Reviewed-on: https://chromium-review.googlesource.com/914981 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#536285} Reviewed-on: https://chromium-review.googlesource.com/927357 Reviewed-by: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/branch-heads/3325@{#517} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/8088889998a4cf81163f79faccb72e7e9a39337a/ash/wm/base_state.cc [modify] https://crrev.com/8088889998a4cf81163f79faccb72e7e9a39337a/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
,
Mar 19 2018
Marked as fixed. #1 and issue 766789 should be fixed in issue 822890 . |
||||
►
Sign in to add a comment |
||||
Comment 1 by warx@chromium.org
, Feb 9 20181.0 MB
1.0 MB View Download