Are these JS alerts that show up in VR using Amir's "2D UI in VR" path? 

is this intent to assign to bsheedy? I am not sure why this assigned to me. It looks like related to test infrastructure.

We indirectly test that alerts and permission prompts cause the fallback UI to be used in https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTransitionTest.java?q=waitfornativeuiprompt&dr=C&l=460, although it only uses the alert and camera permission.

It would be pretty easy to loop through a bunch of cases and ensure each causes a prompt to appear. However, we won't be able to verify that everything looks correct until pixel test stuff is done.

I see. Amir@, do we know a list of js alerts that we need to test?

Thanks Amir!

Removing Internals>VR component and assigning to Internals>XR

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee12ef228a61e3a362c810ac801b9aced95b4e1d

commit ee12ef228a61e3a362c810ac801b9aced95b4e1d
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Tue Aug 14 13:06:29 2018

VR: RenderTest for javascript alert dialog

I also made some changes on Build files to make sure that there is
no circular dependencies.
More tests to come in follow up CLs.

BUG= 810847 

Change-Id: I04fe2d848ebd76a076a09d1c0aab7cdaba9e205a
Reviewed-on: https://chromium-review.googlesource.com/1099563
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582898}
[modify] https://crrev.com/ee12ef228a61e3a362c810ac801b9aced95b4e1d/chrome/android/BUILD.gn
[modify] https://crrev.com/ee12ef228a61e3a362c810ac801b9aced95b4e1d/chrome/android/java_sources.gni
[add] https://crrev.com/ee12ef228a61e3a362c810ac801b9aced95b4e1d/chrome/android/javatests/src/org/chromium/chrome/browser/vr/jsdialog/VrBrowserJavaScriptModalDialogTest.java
[modify] https://crrev.com/ee12ef228a61e3a362c810ac801b9aced95b4e1d/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NativeUiUtils.java
[add] https://crrev.com/ee12ef228a61e3a362c810ac801b9aced95b4e1d/components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr.Pixel_XL-27.png

From chat with Brian re manual testing updates:
1. Can remove alert manual test case.
2. Keep confirm/prompt, but automation is coming soon, and will be updated in this bug.

Assigning to Brian for the confirm/prompt tests.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526

commit 514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Aug 15 16:44:47 2018

Add additional VR browser modal dialog render tests

Adds render tests for JavaScript confirm and prompt dialogs in the VR
browser.

Additionally, cleans the test file up a bit and adds the golden image
directory as a data dependency so that the tests will actually fail on
a mismatch instead of constantly producing new golden images.

Bug:  810847 
Change-Id: I6e4ea25cf6fb84f73ed3a7d90fb02eb5adb9e783
Reviewed-on: https://chromium-review.googlesource.com/1174990
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583279}
[modify] https://crrev.com/514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526/chrome/android/BUILD.gn
[modify] https://crrev.com/514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526/chrome/android/javatests/src/org/chromium/chrome/browser/vr/jsdialog/VrBrowserJavaScriptModalDialogTest.java
[add] https://crrev.com/514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526/components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_alert.Pixel_XL-25.png
[add] https://crrev.com/514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526/components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_alert.Pixel_XL-26.png
[rename] https://crrev.com/514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526/components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_alert.Pixel_XL-27.png
[add] https://crrev.com/514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526/components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_confirm.Pixel_XL-25.png
[add] https://crrev.com/514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526/components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_confirm.Pixel_XL-26.png
[add] https://crrev.com/514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526/components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_prompt.Pixel_XL-25.png
[add] https://crrev.com/514a6aaf6b4c81d4c1d72f641c1c393e4cd9d526/components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_prompt.Pixel_XL-26.png

Alright, I think it's okay to remove the manual tests for these now.

Awesome. Manual tests removed.