For what it's worth, GetUrlFromHeaderBlock() is not used any longer for HTTP/2 pushed streams since https://crrev.com/c/896808.

Actually I plan to eliminate GetUrlFromHeaderBlock() entirely.  It's only called from SpdyStream::SendRequestHeaders(), but the caller can just provide an URL instead (since it generates the header block based on the URL in the first place).

GetUrlFromHeaderBlock() is only called in quic_chromium_client_session.cc and thus can be moved to the anonymous namespace in that file.

Renaming issue, because seems like QUIC needs to be addressed as well as HTTP/2.  Turns out QuicClientPuthPromiseIndex::Try() is using GetPromisedUrlFromHeaders(), but QuicChromiumClientSession::HandlePromised() is the only caller of GetUrlFromHeaderBlock(), which is probably incorrect.

FYI a fix is in progress at https://crrev.com/c/1057414.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c0b8a1e41b38b7930d30baeb33789d7303d741a

commit 4c0b8a1e41b38b7930d30baeb33789d7303d741a
Author: Bence Béky <bnc@chromium.org>
Date: Mon May 14 21:25:38 2018

Use GetPromisedUrlFromHeaders() for QUIC pushed streams.

Just like it is already done for HTTP/2 pushed streams, and it is
already done in QuicClientPuthPromiseIndex::Try() for QUIC pushed
streams, use GetPromisedUrlFromHeaders() instead of
GetUrlFromHeaderBlock() in QuicChromiumClientSession::HandlePromised().

Bug:  810845 
Change-Id: I60a656f6e2d382bf7a1b5e288de4fb42e2a2d4db
Reviewed-on: https://chromium-review.googlesource.com/1057414
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558466}
[modify] https://crrev.com/4c0b8a1e41b38b7930d30baeb33789d7303d741a/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/4c0b8a1e41b38b7930d30baeb33789d7303d741a/net/spdy/spdy_http_utils.cc
[modify] https://crrev.com/4c0b8a1e41b38b7930d30baeb33789d7303d741a/net/spdy/spdy_http_utils.h