Issue metadata
Sign in to add a comment
|
AdSamplerTriggerTest.PageWithMultipleAds is flaky on TSAN |
||||||||||||||||||||
Issue description
,
Feb 12 2018
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/923d74ef495272d30ae67cb2ffce3c9628455536 commit 923d74ef495272d30ae67cb2ffce3c9628455536 Author: Luke Zielinski <lpz@chromium.org> Date: Tue Feb 13 16:44:44 2018 Fix tsan flake caused by ad sampling delay. Seems to be caused by replacing the UI thread's task runner with a test runner. Instead, just give the ad sampler object a test runner. Bug: 810840 Change-Id: I656bda90e80d53a8353b024828f03a334a834e81 Reviewed-on: https://chromium-review.googlesource.com/914532 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#536384} [modify] https://crrev.com/923d74ef495272d30ae67cb2ffce3c9628455536/components/safe_browsing/triggers/ad_sampler_trigger.cc [modify] https://crrev.com/923d74ef495272d30ae67cb2ffce3c9628455536/components/safe_browsing/triggers/ad_sampler_trigger.h [modify] https://crrev.com/923d74ef495272d30ae67cb2ffce3c9628455536/components/safe_browsing/triggers/ad_sampler_trigger_unittest.cc
,
Feb 13 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Feb 9 2018