New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810840 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

AdSamplerTriggerTest.PageWithMultipleAds is flaky on TSAN

Project Member Reported by thomasanderson@chromium.org, Feb 9 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/939486a06a4528cbf69336ac3614f7ffd1e55407

commit 939486a06a4528cbf69336ac3614f7ffd1e55407
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Feb 09 19:44:38 2018

Disable AdSamplerTriggerTest.PageWithMultipleAds on TSAN

BUG= 810840 
TBR=lpz

Change-Id: Ib40f2c459c47df0f3954960e883ac3156af7fa36
Reviewed-on: https://chromium-review.googlesource.com/912152
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535789}
[modify] https://crrev.com/939486a06a4528cbf69336ac3614f7ffd1e55407/components/safe_browsing/triggers/ad_sampler_trigger_unittest.cc

Comment 2 by lpz@chromium.org, Feb 12 2018

Owner: lpz@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/923d74ef495272d30ae67cb2ffce3c9628455536

commit 923d74ef495272d30ae67cb2ffce3c9628455536
Author: Luke Zielinski <lpz@chromium.org>
Date: Tue Feb 13 16:44:44 2018

Fix tsan flake caused by ad sampling delay.

Seems to be caused by replacing the UI thread's task runner with a test runner.
Instead, just give the ad sampler object a test runner.

Bug:  810840 
Change-Id: I656bda90e80d53a8353b024828f03a334a834e81
Reviewed-on: https://chromium-review.googlesource.com/914532
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536384}
[modify] https://crrev.com/923d74ef495272d30ae67cb2ffce3c9628455536/components/safe_browsing/triggers/ad_sampler_trigger.cc
[modify] https://crrev.com/923d74ef495272d30ae67cb2ffce3c9628455536/components/safe_browsing/triggers/ad_sampler_trigger.h
[modify] https://crrev.com/923d74ef495272d30ae67cb2ffce3c9628455536/components/safe_browsing/triggers/ad_sampler_trigger_unittest.cc

Comment 4 by lpz@chromium.org, Feb 13 2018

Status: Fixed (was: Assigned)

Sign in to add a comment