New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 810822 link

Starred by 2 users
Status: Fixed
Owner:
mlamouri@chromium.org
Closed: Feb 2018
Cc:
█ johnpallett@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

HighMEI is propagated to iframes

Project Member Reported by mlamouri@chromium.org, Feb 9 2018 
When the browser process finds that a navigation is linked to a high MEI, it notifies the renderer process about it without checking if it is a main frame or iframe.

I have a fix but will upload it when I have tests for it.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc9e1d68b4ef0144249dee1d231a01e09651e510

commit fc9e1d68b4ef0144249dee1d231a01e09651e510
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Feb 26 19:52:27 2018

Autoplay: only check for high media engagement on main frame.

The bit is sent to all subframes instead of only the main frame. This is
a quick fix until a better one is found that will not break OOPIF.

This CL also de-recursify `HasBeenActivated()`

Bug:  810822 
Change-Id: Ib8f494749221da5ec27f5a9b92d531de6d06a5d9
Reviewed-on: https://chromium-review.googlesource.com/934451
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539243}
[modify] https://crrev.com/fc9e1d68b4ef0144249dee1d231a01e09651e510/chrome/browser/media/media_engagement_autoplay_browsertest.cc
[add] https://crrev.com/fc9e1d68b4ef0144249dee1d231a01e09651e510/chrome/test/data/media/engagement/engagement_autoplay_iframe_delegation.html
[modify] https://crrev.com/fc9e1d68b4ef0144249dee1d231a01e09651e510/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp
[modify] https://crrev.com/fc9e1d68b4ef0144249dee1d231a01e09651e510/third_party/WebKit/Source/core/html/media/AutoplayPolicy.h

Comment 2 by mlamouri@chromium.org, Feb 28 2018

Status: Fixed (was: Started)
The fix should be available on 66.0.3356.0.

I will work on a follow-up to clean up a bit the code but still mark the issue as closed.
►

Sign in to add a comment