New issue
Advanced search Search tips

Issue 810806 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove external estimate provider

Project Member Reported by tbansal@chromium.org, Feb 9 2018

Issue description

Metrics (http://shortn/_fPYbiZn9DQ) show that 75th percentile RTT provided by external estimate provider (EEP) on dogfood devices in US is 10 seconds. This is pretty high and a bit hard to believe. Further, EEP provides estimates on only ~42% connections. Lets remove EEP for now.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/830b47d029a4a4bd993d04042e8d5cab5d75efba

commit 830b47d029a4a4bd993d04042e8d5cab5d75efba
Author: Tarun Bansal <tbansal@google.com>
Date: Sat Feb 10 01:27:23 2018

Labels: M-66
Another CL for this bug: https://chromium-review.googlesource.com/c/chromium/src/+/912553/7
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b4117c3134161c111a9d0d2d14ec82a6dafc21c

commit 9b4117c3134161c111a9d0d2d14ec82a6dafc21c
Author: Tarun Bansal <tbansal@chromium.org>
Date: Thu Feb 22 19:14:16 2018

Remove external estimate provider hookup to Network Quality Estimator

This is the final CL which completely removes the hookup of external estimate provider.

Bug:  810806 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3b764658a4b2dff4eb25fbec71d6d74fdd37955e
TBR: nasko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/925781
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538515}
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
[delete] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/ExternalEstimateProviderAndroid.java
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/chrome/android/java_sources.gni
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/chrome/browser/BUILD.gn
[delete] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/chrome/browser/android/net/external_estimate_provider_android.cc
[delete] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/chrome/browser/android/net/external_estimate_provider_android.h
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/chrome/browser/io_thread.cc
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/components/cronet/cronet_url_request_context.cc
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/content/browser/net_info_browsertest.cc
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/net/BUILD.gn
[delete] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/net/nqe/external_estimate_provider.h
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/net/nqe/network_quality_estimator_test_util.cc
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/9b4117c3134161c111a9d0d2d14ec82a6dafc21c/net/url_request/url_request_unittest.cc

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2446e013cee275c38a7da73b611a4e253ec542a2

commit 2446e013cee275c38a7da73b611a4e253ec542a2
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Mar 07 21:09:13 2018

Mark external estimate provider as deprecated

Bug:  810806 
Change-Id: I9bbea1cb50278a31fe4c95c6cf6c730ad9e37abc
Reviewed-on: https://chromium-review.googlesource.com/944509
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541581}
[modify] https://crrev.com/2446e013cee275c38a7da73b611a4e253ec542a2/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/2446e013cee275c38a7da73b611a4e253ec542a2/net/nqe/network_quality_observation.cc
[modify] https://crrev.com/2446e013cee275c38a7da73b611a4e253ec542a2/net/nqe/network_quality_observation_source.h

Sign in to add a comment