InotifyReader Never Returns from Its Task, Blocking Test Shutdown with MessageLoop Redirection |
||
Issue descriptionInotifyReader (https://cs.chromium.org/chromium/src/base/files/file_path_watcher_linux.cc?l=50&rcl=5b1183d230617aa8e1fd4b2478102d239f1cbf13) creates a thread and posts a single task that in effect never returns. This prevents any sort of task flushing as this task always runs. The fix here is to convert this into a regular non-joinable Platform Thread.
,
Feb 14 2018
As noted in the CL, I don't think that there is actually any need for the InotifyReader to sit blocked in select() in a single task; can we update the implementation to just use FileDescriptorWatcher like everything else?
,
Feb 15 2018
Replaying response from https://chromium-review.googlesource.com/911902 It's an interesting idea. The goal of this change was to unblock redirection of the MessageLoop to the task scheduler and simply migrating the loop was a low-risk no-op way to do it. I have no objects to changing the implementation after that.
,
Feb 21 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 14 2018