location.hash now is encoded
Reported by
david.pr...@gmail.com,
Feb 9 2018
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.51 Safari/537.36 Steps to reproduce the problem: 1. Set `location.hash` to some value that could be encoded, like a quote. 2. Now read this property again. What is the expected behavior? I really don't know what I should expects here, once that I don't know if the Chrome WAS wrong (until 64) or IS wrong now (on 65). Maybe it is a fix (once that Firefox returns the same as Chrome 65 now). But basically, before 65 it returned the value "as is" (the "quote" itself), and now it returns like "%22". Test case: https://jsfiddle.net/ovxwf0a7/ What went wrong? - Did this work before? Yes 64 Does this work in other browsers? No Chrome <64: NOT ENCODED Chrome 65: ENCODED Firefox: ENCODED Edge: NOT ENCODED IE11: NOT ENCODED Chrome version: 65.0.3325.51 Channel: beta OS Version: 10.0 Flash Version:
,
Feb 16 2018
david.proweb@ Thanks for the issue. Tested this issue on Ubuntu 14.04, Mac OS 10.12.6 and Windows 10 on the Beta 65.0.3325.73 and Canary 66.0.3349.0 and able to reproduce the issue by following the steps mentioned above. Bisect Information: =================== Good Build: 65.0.3292.0 (Revision - 523290) Bad Build : 65.0.3293.0 (Revision - 523641) On executing the per-revision bisect script, below is the Changelog URL: https://chromium.googlesource.com/chromium/src/+log/977dc3f7a54c58e74f82cea23abfb2276adec076..01c25d47d2d22456368363e576083d766eedf8f6 From the above Changelog, suspecting the below change: Reviewed-on: https://chromium-review.googlesource.com/719004 mkwst@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner. Adding ReleaseBlock-Stable as this is a recent regression. Please feel to remove the same if it is not applicable. Thanks.
,
Feb 16 2018
M65 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Feb 19 2018
This was an intentional change to align with the spec and other browsers. Chrome's now encoding the characters listed in https://url.spec.whatwg.org/#fragment-percent-encode-set. Thanks for the report! I'll close this out as an intentional change. |
|||
►
Sign in to add a comment |
|||
Comment 1 by krajshree@chromium.org
, Feb 11 2018