New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810797 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Geolocation in use indicator doesn't appear

Project Member Reported by dbbrooks@chromium.org, Feb 9 2018

Issue description

Chrome Version: 66.0.3343.0
OS: Android O
Device: Pixel 2

What steps will reproduce the problem?
(1) Go to https://esri.github.io/html5-geolocation-tool-js/
(2) Accept request to use geolocation
(3) Place device in headset to start VR browsing

What is the expected result? A geolocation icon should appear above the content window.

What happens instead? The geolocation indicator is not there.

(I'm wondering if geolocation was just disabled as soon as I put the device in the headset). Note that the microphone in use indicator does appear.
 
missing_indicator.png
911 KB View Download
indicator.png
933 KB View Download
Labels: M-66 Pri-1 Type-Bug
Owner: asimjour@chromium.org
Status: Assigned (was: Untriaged)
Owner: dbbrooks@chromium.org
I just tried to repro this, and I can't.

I had some trouble initially getting the site to work at all, but it's because I loaded via http:// instead of https://.  Once that was figured out, I'm able to:

- Start geo in 2D, move into VR, and see the indicator.
- Stop and restart geo in VR, and see the indicator disappear and reappear.

David, are you able to re-test this?  I'm not sure if anything has changed code-wise in the past few weeks.
Labels: -Test-Complete
Owner: cjgrant@chromium.org
I take it back - I had the native UI flag enabled that allows granting of permissions in VR.  Without that, the issue exists.
And, according to David, this did previously work, and regressed.

Comment 6 by ericde@google.com, Mar 3 2018

Labels: hotlist-vrb-mvp
Labels: VR-2D-UI
Owner: asimjour@chromium.org
Amir, assigning back to you, as per discussion this morning.

Even though the issue appears to be "fixed" with the 2D UI flag enabled, we agreed we should figure out why it regressed (with flag disabled).
Note that, this doesn't happen anymore. But I keep the bug open to investigate why it happened in the first place.
The original problem was that the permission was denied when we were in VR. So the indicator works as it's expected.
Labels: -M-66 -Hotlist-VRB-MVP M-67
This is still an issue on M66. 66.0.3359.52 Pixel 2 XL, Pixel XL
It repros when the VR browsing native android UI flag is not enabled. AFAIK, that flag will not be enabled in M66. Is that correct?

Repro steps:
(* ensure the VR browsing native android UI flag is not enabled)
(1) Go to https://esri.github.io/html5-geolocation-tool-js/
(2) Accept request to use geolocation
(3) Place device in headset to start VR browsing


Comment 12 by ericde@google.com, Apr 6 2018

Labels: Hotlist-VRB-MVP
Labels: -M-67 -Hotlist-VRB-MVP M-68
Since we don't automatically dismiss the permission dialogs anymore, it does not happen on 67. I remove the label  Hotlist-VRB-MVP but keep the priority as P1 to investigate the problem and make sure that we have tests to make sure that we catch these kinda problems automatically.

Cc: cjgrant@chromium.org
asimjour, should we lower the priority of this one?
Is the bug completely fixed? If so, maybe we should just close it with appropriate labels and open a new issue to add tests.

Until the first question is confirmed, this should remain at the current priority.
On canary 70.0.3512.0, with the browsing native android UI flag disabled, it repros. If the flag is set to default it doesn't repro. So since this flag is on by default, I think we can say it's fixed?


Cc: -cjgrant@chromium.org
Status: Fixed (was: Assigned)
This doesn't happen anymore. I did investigate and even at the time that it was happening the data was not provided to the page in VR. 

Sign in to add a comment