moblabvm: The infra logs directory is no longer correct |
|||
Issue descriptionSee example build: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8955113749805596416 The "INFRA LOGS FROM MOBLAB" links to /var/log/autotest. It used to contain autotest's infrastructure logs. This worked because /usr/local/autotest/logs was a bindmount of /var/log/autotest. But looking at the moblabvm downloaded for that build, mount shows me that we no longer create this bindmount. When did this change? This bindmount is important because that is the only way we get infrastructure logs out of moblab after running moblab_RunSuite.
,
Feb 10 2018
This is where the symlink is supposed to be setup: https://cs.corp.google.com/chromeos_public/src/third_party/chromiumos-overlay/chromeos-base/autotest-server/autotest-server-9999.ebuild?type=cs&q=%22/var/log/autotest%22&sq=package:chromeos&l=52
,
Feb 10 2018
But checking in a moblab vm, both are directories: pprabhu@pprabhu:files$ sshvm 26965 localhost ~ # file /var/log/autotest /var/log/autotest: directory localhost ~ # file /usr/local/autotest/logs /usr/local/autotest/logs: directory
,
Feb 10 2018
/usr/local/autotest is copied out of /autotest Looking at the source: localhost ~ # file /autotest/logs /autotest/logs: directory localhost ~ # ls /autotest/logs README autotest localhost ~ # ls /autotest/logs/autotest localhost ~ # file /autotest/logs/autotest /autotest/logs/autotest: symbolic link to /var/log/autotes Ah ha! So, because .../logs already exists, the dosym command ends up adding a symlink inside the dir. We should delete the .../logs directory first.
,
Feb 10 2018
https://chromium-review.googlesource.com/#/c/chromiumos/overlays/chromiumos-overlay/+/912133
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ba855aeaa1cefaf28e539d3e794deb73613bacba commit ba855aeaa1cefaf28e539d3e794deb73613bacba Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Feb 13 02:59:35 2018 autotest-server: Delete directory before replacing it with symlink. BUG= chromium:810796 TEST=prayers. Change-Id: Iea6d41d4a7c76c246ddc061ea5884a2f8c4ebbad Reviewed-on: https://chromium-review.googlesource.com/912133 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/ba855aeaa1cefaf28e539d3e794deb73613bacba/chromeos-base/autotest-server/autotest-server-9999.ebuild
,
Feb 14 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pprabhu@chromium.org
, Feb 9 2018