New issue
Advanced search Search tips

Issue 810793 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Build-Toolchain

Blocking:
issue 808262



Sign in to add a comment

Use eu-strip on Chromeos-Chrome

Project Member Reported by yunlian@chromium.org, Feb 9 2018

Issue description

We want to use eu-strip to replace binutils stirp to strip chromeos-chrome, this is because strip cannot work well on binaries linked with
lld.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/257203835d82c907a25fd4b6f8afec5962258d4c

commit 257203835d82c907a25fd4b6f8afec5962258d4c
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Thu Feb 15 08:11:00 2018

chromeos-chrome: remove --keep-file-symbols from strip

We want to use eu-strip to strip Chrome binaries. But eu-strip
does not support --keep-file-symbols, so we try to remove it first.

From strip man page, the --keep-file-symbols is used as follows.
When stripping a file, perhaps with --strip-debug or --strip-unneeded,
retain any symbols specifying source file names, which would
otherwise get stripped.

BUG=chromium:810793
TEST=cbuildbot falco-chrome-pfq-tryjob kevin-chrome-pfq-tryjob

Change-Id: Ica93c966aaae80460e313838cc0958d7ef3e0387
Reviewed-on: https://chromium-review.googlesource.com/911931
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/257203835d82c907a25fd4b6f8afec5962258d4c/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Sign in to add a comment