New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810777 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Upgrade rtanaltyics light component to version 2.0

Project Member Reported by weigua@chromium.org, Feb 9 2018

Issue description

We want this change to be merged into Chrome-M65 to support audio-based occupancy detection. 
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 9 2018

Labels: -Merge-Request-65 Merge-Reject-65 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M65 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Feature Type-Bug
Labels: -Hotlist-Merge-Reject -Merge-Reject-65 Merge-Request-65
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 9 2018

Labels: -Merge-Request-65 Merge-Reject-65 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M65 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Feature Type-Bug
Labels: -Hotlist-Merge-Reject -Merge-Reject-65 Merge-Request-65
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 9 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Where is the CL for this?

Can you clarify what the impact of landing this change will be? (e.g. is this specific to the CFM overlay, and only used in CFM cases)
Summary: Upgrade rtanaltyics light component to version 2.0 (was: Upgrade rtanaltyics light component to version 1.2)
Sorry I was about to submit that cl but some last-minute change just happened. You can find the cl here:
https://chromium-review.googlesource.com/c/chromium/src/+/911832

This is basically a tracking bug for the deployment of our machine perception binary for Chromebox for Meetings devices. We have added new features to this binary for performing audio-based occupancy detection. The new binary has been tested on CrOS devices and we would like to merge these changes back to M65 if possible.

The mri_package is part of project-cfm-private overlay, which only goes to guado boards. This machine-perception-service binary is only ever started (via Upstart) on CFM systems.
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5173ffefa24da64919aaebee44ac56dc1ba3b7c2

commit 5173ffefa24da64919aaebee44ac56dc1ba3b7c2
Author: Wei Guan <weigua@chromium.org>
Date: Fri Feb 09 21:42:01 2018

Upgrade rtanaltyics light component to version 2.0.

BUG= 810777 

Change-Id: I73e61af1152dc31d4087f7225cd10d161ce9db36
Reviewed-on: https://chromium-review.googlesource.com/911832
Commit-Queue: Wei Guan <weigua@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535833}
[modify] https://crrev.com/5173ffefa24da64919aaebee44ac56dc1ba3b7c2/chrome/browser/component_updater/cros_component_installer.cc

Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
SGTM, if this is CFM specific please feel free to merge.
Project Member

Comment 13 by sheriffbot@chromium.org, Feb 16 2018

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 20 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/845f16e6bca686ef564cfcfe68d35460c21cddf0

commit 845f16e6bca686ef564cfcfe68d35460c21cddf0
Author: Wei Guan <weigua@chromium.org>
Date: Tue Feb 20 17:15:05 2018

Upgrade rtanaltyics light component to version 2.0.

BUG= 810777 

Change-Id: I73e61af1152dc31d4087f7225cd10d161ce9db36
Reviewed-on: https://chromium-review.googlesource.com/911832
Commit-Queue: Wei Guan <weigua@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535833}(cherry picked from commit 5173ffefa24da64919aaebee44ac56dc1ba3b7c2)
Reviewed-on: https://chromium-review.googlesource.com/926761
Reviewed-by: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#505}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/845f16e6bca686ef564cfcfe68d35460c21cddf0/chrome/browser/component_updater/cros_component_installer.cc

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!

Comment 18 by tbuckley@google.com, Jan 18 (4 days ago)

Components: Enterprise

Comment 19 by bmayer@google.com, Jan 18 (4 days ago)

Status: Verified (was: Assigned)

Sign in to add a comment