New issue
Advanced search Search tips

Issue 810776 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression
Proj-Servicification



Sign in to add a comment

Remove use of URLRequestContextGetter from the network service

Project Member Reported by mmenke@chromium.org, Feb 9 2018

Issue description

URLRequestContextGetter creates the illusion that it owns an entire URLRequestContext, while it actually does not.  If anything with a reference is leaked at shutdown, then we lose data.  While this currently doesn't happen, making the API available makes this easy to do - I've already received a CL for review that I believe may do this.  It also makes object lifetimes difficult to reason about.
 
Summary: Remove use of URLRequestContextGetter from the network service (was: Remove use a URLRequestContextGetter from the network service)
Cc: -rdsmith@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8e15e8e5234ed619a41191690e78034eace05f0

commit e8e15e8e5234ed619a41191690e78034eace05f0
Author: Matt Menke <mmenke@chromium.org>
Date: Thu Apr 19 22:14:13 2018

Remove use of URLRequestContextGetter from the network service.

This API has proven problematic in the past, and the NetworkService has
better defined NetworkContext lifetime semantics, so it's not needed.

Bug:  810776 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6f49a7d7bab973e591e27bb55f17d3fe468d5f20
Reviewed-on: https://chromium-review.googlesource.com/1015823
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552180}
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/chrome/browser/io_thread.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/chrome/browser/safe_browsing/download_protection/download_feedback_unittest.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/chrome/browser/safe_browsing/download_protection/two_phase_uploader_unittest.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/chromecast/browser/network_context_manager.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/chromecast/browser/network_context_manager.h
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/chromecast/browser/network_context_manager_unittest.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/components/safe_browsing/browser/safe_browsing_network_context.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/ios/web/browser_state.mm
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/http_cache_data_remover_unittest.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/network_context.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/network_context.h
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/network_context_unittest.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/network_service.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/url_loader.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/url_loader.h
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/url_loader_factory.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/url_loader_unittest.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/url_request_context_owner.cc
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/url_request_context_owner.h
[modify] https://crrev.com/e8e15e8e5234ed619a41191690e78034eace05f0/services/network/websocket_factory.cc

Comment 4 by mmenke@chromium.org, Apr 19 2018

Status: Fixed (was: Started)

Sign in to add a comment