New issue
Advanced search Search tips

Issue 810773 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

SearchByImage url mismatch between iOS10 and iOS11

Project Member Reported by srikanthg@chromium.org, Feb 9 2018

Issue description

App Version: 66.0.3344.0 canary
iOS Version: 10.3.3, 11.2.5
Device: iPads, iPhones
URL: 

Steps to reproduce:
  1. Launch Google Chrome
  2. Search for Kittens in omnibox
  3. Tap on any Image from Image search results
  4. Long tap on any image and select "Search Google for This Image"
  5. Check the URL of the newly opened tab

Observed results:
On iOS10: URL is displayed as: https://www.google.com/searchbyimage/upload
On iOS11: URL is displayed as: https://www.google.com/search?tbs=sbi:{longKey}

Expected results: Consistent URLs between iOS10 and 11?

Note: Desktop Chrome shows similar URL as iOS11

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: 
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): M64 Yes
Bug reproducible on the current beta channel build (App Version, iOS Version): M65 Yes
 

Comment 1 by pkl@chromium.org, Feb 12 2018

Owner: michaeldo@chromium.org
Status: Assigned (was: Untriaged)
This is expected because we changed the way we do SearchByImage in iOS 11. I just tested on iOS 11, but commented out the new iOS11 POST request code and I am able to reproduce the iOS 10 behavior described here.


iOS 11 adds support for loading requests through WKWebView with a POST body. This allows us to now build the search by image request and send it directly to WKWebView to load the Search Results Page.

On iOS 10 and below, we use a JavaScript hack to send the post request:
https://cs.chromium.org/chromium/src/ios/web/web_state/js/resources/post_request.js

Once we drop iOS 10, we can remove this hack and all OS versions will behave as iOS 11 does today.
Owner: srikanthg@chromium.org
Status: WontFix (was: Assigned)
Thanks for the detailed explanation.

Sign in to add a comment