DownloadNotificationTest.DownloadImageFile in mus_browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) |
||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of olka@google.com Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=DownloadNotificationTest.DownloadImageFile&testType=mus_browser_tests Builders failed on: - Linux Chromium OS ASan LSan Tests (1): https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29
,
Feb 9 2018
,
Feb 9 2018
Another failure (with symbols) Biuld: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/5032 Log: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2Flinux-chromeos-rel%2F5032%2F%2B%2Frecipes%2Fsteps%2Fmus_browser_tests%2F0%2Fstdout [ RUN ] DownloadNotificationTest.DownloadImageFile [31405:31405:0207/120258.133931:WARNING:chrome_browser_main_chromeos.cc(595)] Running as stub user with profile dir: test-user [31405:31405:0207/120259.105031:WARNING:statistics_provider.cc(285)] Statistics loaded after waiting 33ms. [31405:31405:0207/120259.248437:WARNING:user_session_manager.cc(1044)] Attempting to save user password for non enterprise user. [31405:31405:0207/120259.346925:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [31405:31405:0207/120259.347027:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [31405:31405:0207/120259.347114:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [31405:31405:0207/120259.347146:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [31405:31405:0207/120259.503502:ERROR:wallpaper_controller.cc(1259)] User is ephemeral or guest! Fallback to default wallpaper. [31405:31405:0207/120259.602322:ERROR:in_progress_cache_impl.cc(189)] Cache is not initialized, cannot RetrieveEntry. [31405:31405:0207/120259.602345:ERROR:in_progress_cache_impl.cc(173)] Cache is not initialized, cannot AddOrReplaceEntry. [31405:31405:0207/120259.602513:ERROR:in_progress_cache_impl.cc(189)] Cache is not initialized, cannot RetrieveEntry. [31405:31405:0207/120259.606157:ERROR:in_progress_cache_impl.cc(198)] Cache is not initialized, cannot RemoveEntry. [31405:31405:0207/120259.606373:ERROR:in_progress_cache_impl.cc(189)] Cache is not initialized, cannot RetrieveEntry. BrowserTestBase received signal: Terminated. Backtrace: #0 0x0000033f6f5c base::debug::StackTrace::StackTrace() #1 0x0000038e6ce2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7faee9664cb0 <unknown> #3 0x7faee972c6d3 epoll_wait #4 0x00000402313d epoll_dispatch #5 0x000004020c1d event_base_loop #6 0x000003410e04 base::MessagePumpLibevent::Run() #7 0x000003430305 base::RunLoop::Run() #8 0x0000015480b1 (anonymous namespace)::WaitForDownloadNotificationForDisplayService() #9 0x00000153cfe0 DownloadNotificationTest_DownloadImageFile_Test::RunTestOnMainThread() #10 0x0000038e6a3f content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #11 0x0000034effb4 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #12 0x0000034eef2d ChromeBrowserMainParts::PreMainMessageLoopRun() #13 0x0000018e14f5 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #14 0x000002324801 content::BrowserMainLoop::PreMainMessageLoopRun() #15 0x000002652f57 content::StartupTaskRunner::RunAllTasksNow() #16 0x000002322eaa content::BrowserMainLoop::CreateStartupTasks() #17 0x000002326d63 content::BrowserMainRunnerImpl::Initialize() #18 0x000002320c84 content::BrowserMain() #19 0x0000033ce136 content::ContentMainRunnerImpl::Run() #20 0x0000050f8336 service_manager::Main() #21 0x0000033ccd84 content::ContentMain() #22 0x0000038e670d content::BrowserTestBase::SetUp() #23 0x0000034b1f42 InProcessBrowserTest::SetUp() #24 0x000001bc96a1 testing::Test::Run() #25 0x000001bca270 testing::TestInfo::Run() #26 0x000001bca757 testing::TestCase::Run() #27 0x000001bd1c87 testing::internal::UnitTestImpl::RunAllTests() #28 0x000001bd18d7 testing::UnitTest::Run() #29 0x0000034c4d52 base::TestSuite::Run() #30 0x0000033ecbf9 ChromeTestSuiteRunner::RunTestSuite() #31 0x0000033ecb70 (anonymous namespace)::MusTestLauncherDelegate::RunTestSuite() #32 0x000003916390 content::LaunchTests() #33 0x0000033ed0c4 LaunchChromeTests() #34 0x0000033ec906 RunMashBrowserTests() #35 0x0000033ec7b7 main #36 0x7faee964ff45 __libc_start_main #37 0x0000005c8eda _start [592/864] DownloadNotificationTest.DownloadImageFile (TIMED OUT)
,
Feb 9 2018
,
Feb 9 2018
,
Feb 9 2018
Disabling test here https://chromium-review.googlesource.com/c/chromium/src/+/911569
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3cffb9585a094d4382776fed0652da221dc31d2 commit d3cffb9585a094d4382776fed0652da221dc31d2 Author: Olga Sharonova <olka@chromium.org> Date: Fri Feb 09 16:05:13 2018 Disabling DownloadNotificationTest.DownloadImageFile: flaky on ChromeOS TBR=peter@chromium.org, dtrainor@chromium.org Bug: 810738 Change-Id: I00616295cc17e72ed6763eab3aac1c8aa9ae6794 Reviewed-on: https://chromium-review.googlesource.com/911569 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#535726} [modify] https://crrev.com/d3cffb9585a094d4382776fed0652da221dc31d2/chrome/browser/download/notification/download_notification_browsertest.cc
,
Feb 9 2018
,
Mar 1 2018
@estade can you ptal as this disable reduces test coverage?
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28322d7a97eb3e7d757e4dbca01681a2230f1853 commit 28322d7a97eb3e7d757e4dbca01681a2230f1853 Author: Evan Stade <estade@chromium.org> Date: Fri Mar 02 00:06:26 2018 Download notification tests: browser tests => interactive ui tests Also, re-enable the tests which had been identified as flaky. Bug: 810738 , 810302 Change-Id: Ieafb9a09450f4a3a61f2e1e14d40dc93366a875d Reviewed-on: https://chromium-review.googlesource.com/938362 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#540358} [rename] https://crrev.com/28322d7a97eb3e7d757e4dbca01681a2230f1853/chrome/browser/download/notification/download_notification_interactive_uitest.cc [modify] https://crrev.com/28322d7a97eb3e7d757e4dbca01681a2230f1853/chrome/test/BUILD.gn
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0816757edbe7e9d5ef98e6b7d1585d82e41a5844 commit 0816757edbe7e9d5ef98e6b7d1585d82e41a5844 Author: Evan Stade <estade@chromium.org> Date: Fri Mar 09 03:24:16 2018 [Chrome OS] Fixes for download shutdown path. a) if a dangerous download is cancelled, don't try to update it (with a potentially half-destroyed profile). Like other notification types, just close and return. b) make the download service depend on the NotificationDisplayService. Bug: 810302, 810738 , 578868 Change-Id: Ibc3080510e128954e233485606d8de520b72a97c Reviewed-on: https://chromium-review.googlesource.com/956087 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#542010} [modify] https://crrev.com/0816757edbe7e9d5ef98e6b7d1585d82e41a5844/chrome/browser/download/download_core_service_factory.cc [modify] https://crrev.com/0816757edbe7e9d5ef98e6b7d1585d82e41a5844/chrome/browser/download/notification/download_item_notification.cc
,
Mar 15 2018
@estade Thanks for checking! Is this good to mark as fixed now?
,
Mar 15 2018
I re-enabled one test (see bug 810302 ) but I can't tell if it's no longer flaky or just not running or I'm just not reading the dashboard right.
,
Nov 5
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by olka@chromium.org
, Feb 9 2018Labels: OS-Chrome