New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 810731 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
█ rspangler@chromium.org
scott.wo...@microchip.corp-partner.google.com
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

EC: the pack_ec.py mchp tool is blasting large traces during *quiet* builds

Reported by vpalatin@chromium.org, Feb 9 2018 
By default, the tools run by the EC build should not have a verbose output until V=1 parameter is passed.
chip/mchp/build.mk is incorrectly spewing tons of debug output.
Please have a look at Makefile.rules and the 'quiet' function as called by  '$(call quiet,obj_to_bin,OBJCOPY)'

e.g.
# make buildall -j

  OBJCOPY ec.bin
  COPY_RW ec.bin
  CAT     ec.obj
  MV      ec.bin
  OBJCOPY ec.bin
  COPY_RW ec.bin
  MV      ec.bin
  OBJCOPY ec.bin
Begin MEC17xx pack_ec.py script
CWD = chip/mchp/util
parsed arguments:
.input  =  build/mchpevb1/ec.bin.tmp1
.output =  build/mchpevb1/ec.bin.tmp
.loader_file =  build/mchpevb1/RW/chip/mchp/lfw/ec_lfw-lfw.flat
.spi_size (KB) =  0x200
.image_size =  0x2f000
.header_loc =  0x1000
.payload_offset =  0x80
.rwheader_loc =  0x40000
.spi_clock =  24
.spi_read_cmd =  11
.test_spi =  False
SPI Flash image size in bytes = 0x80000
args.input =  build/mchpevb1/ec.bin.tmp1
args.loader_file =  build/mchpevb1/RW/chip/mchp/lfw/ec_lfw-lfw.flat
args.image_size =  0x2f000
  COPY_RW ec.bin
EC_LFW + EC_RO length =  0x30000
Signature is SHA-256 of data
LFW + EC_RO payload_signature = 
0xd0, 0xfd, 0x2b, 0x47, 0x68, 0x99, 0xb3, 0x56, 
0xc4, 0x2d, 0xe4, 0xe2, 0xdc, 0x4a, 0xc0, 0x6c, 
0x0f, 0x6b, 0x6c, 0x03, 0x42, 0x6c, 0xf1, 0x08, 
0x97, 0x6e, 0xe6, 0xec, 0x8d, 0x80, 0x71, 0xb6, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 


Header LFW + EC_RO = 
0x50, 0x48, 0x43, 0x4d, 0x00, 0x05, 0x00, 0x01, 
0x00, 0x00, 0x0e, 0x00, 0x79, 0x09, 0x0e, 0x00, 
0x00, 0x0c, 0x00, 0x00, 0x80, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 


Signature is SHA-256 of data
header_signature = 
0x18, 0x4c, 0x39, 0xac, 0xf4, 0x0b, 0xbb, 0x12, 
0x7e, 0x02, 0xee, 0x74, 0xd5, 0x2d, 0x9b, 0xe6, 
0xbb, 0x3c, 0x72, 0x0e, 0xd6, 0xb2, 0x15, 0x46, 
0x61, 0x3c, 0xd3, 0x86, 0x09, 0x01, 0x9e, 0x5f, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 


Call to GetPayloadFromOffset
args.input =  build/mchpevb1/ec.bin.tmp1
args.image_size =  0x2f000
type(payload_rw) is  <type 'bytearray'>
len(payload_rw) is  0x50000
Truncated size of EC_RW =  0x2f000
payload_entry_tuple =  (922341,)
payload_entry =  0xe12e5
Signature is SHA-256 of data
  MV      ec.bin
payload_rw_sig = 
0x61, 0x1a, 0x95, 0x28, 0x72, 0x20, 0x9c, 0x36, 
0x2a, 0x5c, 0x25, 0x90, 0x77, 0xb4, 0xf4, 0x92, 
0xec, 0xab, 0xd1, 0x03, 0x37, 0x8e, 0xd8, 0x5b, 
0x07, 0x1d, 0x8d, 0x6b, 0x43, 0x83, 0x8a, 0xdc, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 


Header EC_RW = 
0x50, 0x48, 0x43, 0x4d, 0x00, 0x05, 0x00, 0x01, 
0x00, 0x10, 0x0e, 0x00, 0xe5, 0x12, 0x0e, 0x00, 
0xc0, 0x0b, 0x00, 0x00, 0x80, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 


Signature is SHA-256 of data
header_rw_sig = 
0x64, 0x17, 0x53, 0x3d, 0x2e, 0x94, 0x05, 0x32, 
0x7d, 0xf3, 0xfe, 0x1b, 0x02, 0xce, 0x3d, 0xef, 
0xf1, 0x10, 0x22, 0x74, 0xa9, 0x95, 0x81, 0xd4, 
0x76, 0x93, 0xa9, 0x33, 0x54, 0x0d, 0x29, 0x0b, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 


0x0 0x4 tag
0x1000 0x40 header(lwf + ro)
0x1040 0x40 header(lwf + ro) signature
0x1080 0x30000 payload(lfw + ro)
0x31080 0x40 payload(lfw_ro) signature
0x40000 0x40 header(rw)
0x40040 0x40 header(rw) signature
0x40080 0x2f000 payload(rw)
0x6f080 0x40 payload(rw) signature
Write spi list to file build/mchpevb1/ec.bin.tmp
Offset  0x0  Length 0x4 write data
Offset  0x4  Length 0xffc fill with 0xff
Offset  0x1000  Length 0x40 write data
Offset  0x1040  Length 0x40 write data
Offset  0x1080  Length 0x30000 write data
Offset  0x31080  Length 0x40 write data
Offset  0x310c0  Length 0xef40 fill with 0xff
Offset  0x40000  Length 0x40 write data
Offset  0x40040  Length 0x40 write data
Offset  0x40080  Length 0x2f000 write data
Offset  0x6f080  Length 0x40 write data
Offset  0x6f0c0  Length 0x10f40 fill with 0xff
  COPY_RW ec.bin
  MV      ec.bin
  OBJCOPY ec.bin
  MV      ec.bin

Comment 1 by scott.wo...@microchip.corp-partner.google.com, Feb 9 2018 

Uploaded Gerrit 911749.
Changed chip/mchp/util/pack_ec.py to not print by default and added --verbose option.
Changed chip/mchp/build.mk to pass pass --verbose to pack_ec.py only if V=1 passed to make.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/f8da6be34b57e9c99cda56a9423a24e7045fbfc6

commit f8da6be34b57e9c99cda56a9423a24e7045fbfc6
Author: Scott Worley <scott.worley@microchip.corp-partner.google.com>
Date: Sat Feb 10 03:03:26 2018

chip/mchp: Default SPI image script verobse output to disabled

Disable MCHP chip Python SPI image generator verbose output.
Verbose output only enabled if V=1 passed on make command line.
Implemented by importing print as function and overloading.

BRANCH=none
BUG=810731
TEST=Build mchpevb1 with command line V unset, V=0, and V=1.

Change-Id: I3da02b97796a8fe95f5e54634b84c962e14a19bf
Signed-off-by: Scott Worley <scott.worley@microchip.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/911749
Commit-Ready: Randall Spangler <rspangler@chromium.org>
Tested-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/f8da6be34b57e9c99cda56a9423a24e7045fbfc6/chip/mchp/util/pack_ec.py
[modify] https://crrev.com/f8da6be34b57e9c99cda56a9423a24e7045fbfc6/chip/mchp/build.mk
►

Sign in to add a comment