New issue
Advanced search Search tips

Issue 810727 link

Starred by 2 users

Issue metadata

Status: Unconfirmed
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Incorrect use of non_needed in extensions/browser/api/networking_private/BUILD.gn

Reported by aoakley....@gmail.com, Feb 9 2018

Issue description

Chrome Version       : 65.0.3325.56

In extensions/browser/api/networking_private/BUILD.gn there is a line that says:
  not_needed(default_sources)

The argument to not_needed should be a list of the names of variables that are not needed, so this is not correct usage.  Inside gn we end up hitting the NOTREACHED() line in Scope::MarkUsed as the and in some builds this ends up terminating gn.

To reproduce this issue:
(1) $ tools/gn/bootstrap/bootstrap.py --debug --no-rebuild --output=out/gn
(2) $ out/gn/gn gen out/default

I find that gn aborts at the location described above.

It feels a bit like there are two issues here, the first is that the BUILD.gn file is wrong and the second is that gn doesn't detect this and display a useful error message.
 
Labels: Needs-Triage-M65
Components: Build
Labels: Triaged-ET TE-NeedsTriageHelp
The issue seems to be out of TE-scope as it is related to build. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team.

Thanks...!!

Sign in to add a comment