New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810704 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Omnibox links autocomplete but when pressed enter will search for what ever was typed in

Reported by pacuka...@gmail.com, Feb 9 2018

Issue description

Steps to reproduce the problem:
1. Type in the first few letters of a website.
2. Suggestion for the website comes up, and the link is autocompleted.
3. Select enter, searches for what ever was typed in instead if going to the link

What is the expected behavior?
When I do the steps above, I expect to go to the website instead of google search which showes me the results of the first few lettera for the website i wanted to go to.

What went wrong?
I was brought to a google search page instead of going to the website.

Did this work before? Yes No Idea

Chrome version: 64.0.3282.137  Channel: stable
OS Version: 8.0
Flash Version: Don't know
 
Screenshot_20180209-100506.png
233 KB View Download
Screenshot_20180209-100512.png
340 KB View Download
Labels: Needs-triage-Mobile
Cc: sandeepkumars@chromium.org
Labels: Needs-Feedback Triaged-Mobile
Tested the issue in Android and couldn't reproduce the issue as per the steps mentioned in original comment.

Chrome versions tested:
64.0.3282.137

OS:
Android 8.0.0

Android Devices:
Pixel XL

@pacukas19 -- Could you please help us with the details of your device and if possible attach a screencast for further triaging of the issue.

Thanks!!

Components: -UI UI>Browser>Omnibox

Comment 4 by pacuka...@gmail.com, Feb 14 2018

Hello, the device that I am using is HTC 10 with TouchPal keyboard (default) came with the phone. I have attached 4 more screenshots of the same problem. I have tried uninstalling all TouchPal updates and I was having the same problem. I tried to reproduce the same issue on another HTC device HTC One m8 and everything was fine. 

Thank you.
Screenshot_20180214-171144.png
205 KB View Download
Screenshot_20180214-171200.png
332 KB View Download
Screenshot_20180214-171405.png
198 KB View Download
Screenshot_20180214-171411.png
374 KB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 14 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "sandeepkumars@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-TestConfirmation
Testing team, do you have a "HTC 10 with TouchPal keyboard" that you can test this on?
Labels: -Triaged-Mobile
Removing Triaged-Mobile since feedback was provided (and the status hasn't changed).
Components: UI>Browser>Mobile>TouchToSearch
Labels: -Needs-TestConfirmation Triaged-Mobile
Tested the issue using #65.0.3325.109 HTC 10 and could observe the same behavior as mentioned in original comment.

This looks to be a Search issue rather a issue on Chrome.

Adding related components and Requesting dev team to take a look at this issue.

Thanks!!
Cc: tedc...@chromium.org changwan@chromium.org
Labels: -Pri-2 Pri-3
Ted or Changwan, can you find someone to look into this?  It reproduces (only?) on HTC 10 with TouchPal keyboard, and I don't know to begin investigating something that's specific to a particular device and keyboard.
Status: Available (was: Unconfirmed)
Owner: tedc...@chromium.org
Status: Assigned (was: Available)
Assigning to Ted for delegation.
Owner: changwan@chromium.org
I can work on this, sorry I didn't reply earlier.
Labels: -Pri-3 M-67 Pri-2
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12d34bdf8f8a3ee172651e5c81eca24373594226

commit 12d34bdf8f8a3ee172651e5c81eca24373594226
Author: Changwan Ryu <changwan@google.com>
Date: Wed Apr 25 00:37:15 2018

Fix performEditorAction to commit autocomplete text in batch edits

The commitAutocomplete logic was assuming that the autocomplete span
was present and was trying to commit it, but when between onBeginImeCommand
/ onEndImeCommand, we have removed the span in onBeginImeCommand(), so
there is nothing to commit. We just need to commit the text, which does
not interfere with onEndImeCommand() logic.

BUG= 810704 

Change-Id: Iec7928d2154b6f4c4c8c6197293b6c84fde828f5
Reviewed-on: https://chromium-review.googlesource.com/1020064
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553393}
[modify] https://crrev.com/12d34bdf8f8a3ee172651e5c81eca24373594226/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SpannableAutocompleteEditTextModel.java
[modify] https://crrev.com/12d34bdf8f8a3ee172651e5c81eca24373594226/chrome/android/junit/src/org/chromium/chrome/browser/omnibox/AutocompleteEditTextTest.java

Labels: Merge-Request-67
Status: Fixed (was: Assigned)
Please verify in canary
Project Member

Comment 17 by sheriffbot@chromium.org, Apr 26 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by sheriffbot@chromium.org, Apr 30 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 30 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebb7e414218e2fa43ae246446663c65fbd380130

commit ebb7e414218e2fa43ae246446663c65fbd380130
Author: Changwan Ryu <changwan@google.com>
Date: Mon Apr 30 18:11:17 2018

Fix performEditorAction to commit autocomplete text in batch edits

The commitAutocomplete logic was assuming that the autocomplete span
was present and was trying to commit it, but when between onBeginImeCommand
/ onEndImeCommand, we have removed the span in onBeginImeCommand(), so
there is nothing to commit. We just need to commit the text, which does
not interfere with onEndImeCommand() logic.

BUG= 810704 

Change-Id: Iec7928d2154b6f4c4c8c6197293b6c84fde828f5
Reviewed-on: https://chromium-review.googlesource.com/1020064
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553393}(cherry picked from commit 12d34bdf8f8a3ee172651e5c81eca24373594226)
Reviewed-on: https://chromium-review.googlesource.com/1035643
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#383}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/ebb7e414218e2fa43ae246446663c65fbd380130/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SpannableAutocompleteEditTextModel.java
[modify] https://crrev.com/ebb7e414218e2fa43ae246446663c65fbd380130/chrome/android/junit/src/org/chromium/chrome/browser/omnibox/AutocompleteEditTextTest.java

Sign in to add a comment