This issue is to track Chrome side work of b/64776170.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f56c1c181f50cac1aa8bf912321db1e3a16b074d commit f56c1c181f50cac1aa8bf912321db1e3a16b074d Author: yoshiki iguchi <yoshiki@chromium.org> Date: Tue Feb 13 07:26:49 2018 Move expanding stuff from contents view to notification view This CL moves the expanding-related code in ArcNotificationContentsView to ArcNotificationView. This is to make consistency with other notification views and reduce methods in ArcNotificationContentsViewDelegate. This is a clean-up CL and doesn't change any behavior. Bug: 810656 Test: None Change-Id: I05aa6bff9beb07ac081eb8de8a5b2ab15f73dea0 Reviewed-on: https://chromium-review.googlesource.com/910469 Reviewed-by: Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#536276} [modify] https://crrev.com/f56c1c181f50cac1aa8bf912321db1e3a16b074d/ui/arc/notification/arc_notification_content_view.cc [modify] https://crrev.com/f56c1c181f50cac1aa8bf912321db1e3a16b074d/ui/arc/notification/arc_notification_content_view.h [modify] https://crrev.com/f56c1c181f50cac1aa8bf912321db1e3a16b074d/ui/arc/notification/arc_notification_content_view_delegate.h [modify] https://crrev.com/f56c1c181f50cac1aa8bf912321db1e3a16b074d/ui/arc/notification/arc_notification_delegate.cc [modify] https://crrev.com/f56c1c181f50cac1aa8bf912321db1e3a16b074d/ui/arc/notification/arc_notification_view.cc [modify] https://crrev.com/f56c1c181f50cac1aa8bf912321db1e3a16b074d/ui/arc/notification/arc_notification_view.h [modify] https://crrev.com/f56c1c181f50cac1aa8bf912321db1e3a16b074d/ui/arc/notification/arc_notification_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88817201ec14e5657df07837710e175c0b887a48 commit 88817201ec14e5657df07837710e175c0b887a48 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Mar 01 06:22:47 2018 Expand the notification at the top of the message center This CL adds auto-expanding of notification at the top of the message center. If the notification at top is expandable and never manually-expanded-or-collapsed, the message center expands it automatically. And This Cl also implements the manually-expanded-or-collapsed flag on ARC notifications, which has been already implemented for non-ARC notification. Bug: 810656 Test: manual test Change-Id: I50fe1d15271ad8d38f889b65a6dcccc8d82ff403 Reviewed-on: https://chromium-review.googlesource.com/915642 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Eliot Courtney <edcourtney@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#540071} [modify] https://crrev.com/88817201ec14e5657df07837710e175c0b887a48/ash/message_center/message_list_view.cc [modify] https://crrev.com/88817201ec14e5657df07837710e175c0b887a48/ash/message_center/message_list_view.h [modify] https://crrev.com/88817201ec14e5657df07837710e175c0b887a48/ui/arc/notification/arc_notification_content_view.h [modify] https://crrev.com/88817201ec14e5657df07837710e175c0b887a48/ui/arc/notification/arc_notification_content_view_unittest.cc [modify] https://crrev.com/88817201ec14e5657df07837710e175c0b887a48/ui/arc/notification/arc_notification_item.h [modify] https://crrev.com/88817201ec14e5657df07837710e175c0b887a48/ui/arc/notification/arc_notification_item_impl.cc [modify] https://crrev.com/88817201ec14e5657df07837710e175c0b887a48/ui/arc/notification/arc_notification_item_impl.h [modify] https://crrev.com/88817201ec14e5657df07837710e175c0b887a48/ui/arc/notification/arc_notification_view.cc [modify] https://crrev.com/88817201ec14e5657df07837710e175c0b887a48/ui/arc/notification/arc_notification_view.h [modify] https://crrev.com/88817201ec14e5657df07837710e175c0b887a48/ui/arc/notification/arc_notification_view_unittest.cc
Ah, I forgot that I have one pending CL.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8364e2978da3f094362c2eda985461f42f02be77 commit 8364e2978da3f094362c2eda985461f42f02be77 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Mar 08 06:45:45 2018 Do not auto-expand bundled notifications In the original Android and the previous ARC, the bundle notification was not expanded automatically, because their height may be too long vertically to expand. We recentlly re-implementing auto-expander in Chrome-side. This CL implements that behavior to Chrome auto-expander. Bug: 810656 Test: manual test Change-Id: Ie6cc878fff04148402448ddd2aa4f02f6541164b Reviewed-on: https://chromium-review.googlesource.com/942129 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#541741} [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ash/message_center/message_list_view.cc [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/components/arc/common/notifications.mojom [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ui/arc/notification/arc_notification_content_view_unittest.cc [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ui/arc/notification/arc_notification_item.h [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ui/arc/notification/arc_notification_item_impl.cc [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ui/arc/notification/arc_notification_item_impl.h [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ui/arc/notification/arc_notification_view.cc [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ui/arc/notification/arc_notification_view.h [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ui/arc/notification/arc_notification_view_unittest.cc [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ui/message_center/views/message_popup_collection.cc [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ui/message_center/views/message_view.cc [modify] https://crrev.com/8364e2978da3f094362c2eda985461f42f02be77/ui/message_center/views/message_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/331599edc15f05cf61166900c9c7d46cade70dc9 commit 331599edc15f05cf61166900c9c7d46cade70dc9 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Mon Mar 19 08:30:28 2018 Remove junk while auto-expansion of notifications We recently re-implemented auto-expansion of notification ( crbug.com/810656 ), but it sometimes caused some junkness while animation when it was auto-expanded. That was because auto-expanded is done in the final phase of layouting. This CL moves the auto-expansion to earlier phase: - (on add): just before the view is added to the list - (on update): just before the view is updated in the list - (on remove): just after the view is removed from the list Bug: 810656 Test: manual Change-Id: I015f45f74eef37f89f11edc1b3b346d18771862c Reviewed-on: https://chromium-review.googlesource.com/958757 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#543990} [modify] https://crrev.com/331599edc15f05cf61166900c9c7d46cade70dc9/ash/message_center/message_center_view_unittest.cc [modify] https://crrev.com/331599edc15f05cf61166900c9c7d46cade70dc9/ash/message_center/message_list_view.cc [modify] https://crrev.com/331599edc15f05cf61166900c9c7d46cade70dc9/ash/message_center/message_list_view.h
Issue 801825 has been merged into this issue.
Comment 1 by bugdroid1@chromium.org
, Feb 13 2018