New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810644 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mash: AccessibilityManagerLoginTest.Login failing due to accessibility_autoclick manifest permissions

Project Member Reported by jamescook@chromium.org, Feb 9 2018

Issue description

Started https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20ChromiumOS/26742

Probably due to https://chromium-review.googlesource.com/857363

I'll bet we're missing the accessibility_autoclick app in a manifest somewhere.

[18406:18439:0208/192153.590298:FATAL:service_manager.cc(154)] Check failed: false. The Service Manager prevented service "ash" from binding interface "ash::autoclick::mojom::AutoclickController" in target service "accessibility_autoclick". You probably need to update one or more service manifests to ensure that "accessibility_autoclick" exposes "ash::autoclick::mojom::AutoclickController" through a capability and that "ash" requires that capability from the "accessibility_autoclick" service.
#0 0x000003ec65ac base::debug::StackTrace::StackTrace()
#1 0x000003ee07fc logging::LogMessage::~LogMessage()
#2 0x000002545329 service_manager::(anonymous namespace)::ReportBlockedInterface()
#3 0x000002544ccb service_manager::(anonymous namespace)::AllowsInterface()
#4 0x000002541b06 service_manager::ServiceManager::Instance::CallOnBindInterface()
#5 0x0000025404c4 service_manager::ServiceManager::Connect()
#6 0x000002546c1c service_manager::ServiceManager::Instance::BindInterface()
#7 0x0000052afb1e service_manager::mojom::ConnectorStubDispatch::AcceptWithResponder()
#8 0x0000025445f6 service_manager::mojom::ConnectorStub<>::AcceptWithResponder()
#9 0x0000051c7f8c mojo::InterfaceEndpointClient::HandleValidatedMessage()
#10 0x0000051c7ba6 mojo::FilterChain::Accept()
#11 0x0000051c9325 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#12 0x0000051cef8d mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#13 0x0000051ce4cc mojo::internal::MultiplexRouter::Accept()
#14 0x0000051c7ba6 mojo::FilterChain::Accept()
#15 0x0000051c5d65 mojo::Connector::ReadSingleMessage()
#16 0x0000051c6681 mojo::Connector::ReadAllAvailableMessages()
#17 0x0000051c6529 mojo::Connector::OnHandleReadyInternal()
#18 0x0000025279a7 mojo::SimpleWatcher::DiscardReadyState()
#19 0x0000051c0a76 mojo::SimpleWatcher::OnHandleReady()
#20 0x0000051c0eb7 mojo::SimpleWatcher::Context::Notify()
#21 0x0000051bfb54 mojo::SimpleWatcher::Context::CallNotify()
#22 0x0000060b7d08 mojo::edk::Watch::InvokeCallback()
#23 0x0000060b363f mojo::edk::RequestContext::~RequestContext()
#24 0x0000060bf39f mojo::edk::NodeChannel::OnChannelMessage()
#25 0x0000060bdab2 mojo::edk::Channel::OnReadComplete()
#26 0x0000060c0da7 mojo::edk::(anonymous namespace)::ChannelPosix::OnFileCanReadWithoutBlocking()
#27 0x000003eea523 base::MessagePumpLibevent::OnLibeventNotification()
#28 0x000004e7338d event_base_loop
#29 0x000003eea75e base::MessagePumpLibevent::Run()
#30 0x000003ee7ab9 base::MessageLoop::Run()
#31 0x000003f12fd9 base::RunLoop::Run()
#32 0x000003f3ff17 base::Thread::Run()
#33 0x000002757108 content::BrowserThreadImpl::IOThreadRun()
#34 0x000002757255 content::BrowserThreadImpl::Run()
#35 0x000003f404cc base::Thread::ThreadMain()
#36 0x000003f39dff base::(anonymous namespace)::ThreadFunc()
#37 0x7f483dd86184 start_thread
#38 0x7f483aa85ffd clone

 
Status: Started (was: Assigned)
I think it's just a missing entry in //ash/manifest.json

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e5fdb3288adc37d8479c7f8a84b6adf15df2ff5

commit 0e5fdb3288adc37d8479c7f8a84b6adf15df2ff5
Author: James Cook <jamescook@chromium.org>
Date: Fri Feb 09 18:03:46 2018

cros: Fix ash mojo manifest for accessibility_autoclick

The ash manifest was missing an interface import ("required") for an
interface on the accessibility_autoclick mini-app. This was revealed
after https://chromium-review.googlesource.com/857363 moved some
accessibility code from browser to ash. Under mash both the browser
and ash are trusted processes, and both need to control the autoclick
app, so add the manifest entry.

This fixes AccessibilityManagerLoginTest on mash_browser_tests.

Bug:  810644 
Test: mash_browser_tests
Change-Id: I8cd5c4456e58f4585ef32d2e7f4bb81fcd1c24c7
Reviewed-on: https://chromium-review.googlesource.com/910713
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535751}
[modify] https://crrev.com/0e5fdb3288adc37d8479c7f8a84b6adf15df2ff5/ash/manifest.json

Status: Fixed (was: Started)
Mojo FYI bot mash_browser_tests is green.

Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment