compile failure on chromium/Mac |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of ksakamoto@google.com compile failure on chromium/Mac Builders failed on: - Mac: https://build.chromium.org/p/chromium/builders/Mac [3202/60012] CXX obj/remoting/host/main/host_main.o FAILED: obj/remoting/host/main/host_main.o export DEVELOPER_DIR=/b/c/b/mac/src/build/mac_files/Xcode.app; /b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/remoting/host/main/host_main.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_XCODE_VERSION=0832 -DCR_CLANG_REVISION=\"321529-2\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -fno-strict-aliasing -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wthread-safety -Wimplicit-fallthrough -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-constant-compare -Wtautological-constant-out-of-range-compare -O2 -fno-omit-frame-pointer -gdwarf-2 -isysroot ../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c++14 -stdlib=libc++ -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../remoting/host/host_main.cc -o obj/remoting/host/main/host_main.o In file included from ../../remoting/host/host_main.cc:27: In file included from ../../remoting/host/setup/me2me_native_messaging_host.h:17: In file included from ../../extensions/browser/api/messaging/native_message_host.h:11: In file included from ../../base/single_thread_task_runner.h:9: In file included from ../../base/sequenced_task_runner.h:13: In file included from ../../base/task_runner.h:12: ../../base/location.h:14:10: fatal error: 'base/debug/debugging_flags.h' file not found #include "base/debug/debugging_flags.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16f1f4f7e25ba9a60fae325e2a929bb15c75bbd8 commit 16f1f4f7e25ba9a60fae325e2a929bb15c75bbd8 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Fri Feb 09 03:52:02 2018 Revert "Add //base:debugging_flags as a dependency for remoting/host." This reverts commit bb47b7135c19a8be7b18a7d76169de301a4fb4cf. Reason for revert: It didn't fix the build error. Original change's description: > Add //base:debugging_flags as a dependency for remoting/host. > > This is a speculative fix for the compile failure on chromium/Mac. > > TBR=zijiehe@chromium.org > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 810620 > Change-Id: Id398afe2212fcb30e3bd716767a8a6344a95bc56 > Reviewed-on: https://chromium-review.googlesource.com/910728 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535619} TBR=ksakamoto@chromium.org,joedow@chromium.org,zijiehe@chromium.org Change-Id: I53bdd46ffc3359eca3750f9331654de8744d609a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 810620 Reviewed-on: https://chromium-review.googlesource.com/910330 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#535620} [modify] https://crrev.com/16f1f4f7e25ba9a60fae325e2a929bb15c75bbd8/remoting/host/BUILD.gn
,
Feb 9 2018
https://uberchromegw.corp.google.com/i/chromium/builders/Mac/builds/37990 is running without the compile error. Not adding dependency but its revert did the trick...???
,
Feb 9 2018
It failed again :(
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd421690f914a20eb2893c6377b32f10aa2bbfe6 commit dd421690f914a20eb2893c6377b32f10aa2bbfe6 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Fri Feb 09 05:09:16 2018 Add //base:debugging_flags as a dependency for remoting/host main source_sets This is a speculative fix for the compile failure on chromium/Mac. TBR=joedow@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 810620 Change-Id: Ib63ca82376ba3a1969293371c976c9a589dec079 Reviewed-on: https://chromium-review.googlesource.com/910730 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#535646} [modify] https://crrev.com/dd421690f914a20eb2893c6377b32f10aa2bbfe6/remoting/host/BUILD.gn [modify] https://crrev.com/dd421690f914a20eb2893c6377b32f10aa2bbfe6/remoting/host/security_key/BUILD.gn
,
Feb 9 2018
,
Feb 9 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 9 2018