Issue metadata
Sign in to add a comment
|
Extensions: Extensions.ExtensionFrameMapCacheHit UMA has regressed. |
||||||||||||||||||||
Issue descriptionFrom UMA: V60-> 99.8% cache hits V61-> 99.8% cache hits V62-> 95.9% V63-> 94.2% V64-> 94.8% Example- https://uma.googleplex.com/p/chrome/histograms/?endDate=20180207&dayCount=28&histograms=Extensions.ExtensionFrameMapCacheHit&fixupData=true&showMax=true&filters=simple_version%2Cregex%2C60.*%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial. This will cause increased no of thread hops between the IO and UI thread.
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c9b088f18a3ea440d166482e59004bf0c536422 commit 5c9b088f18a3ea440d166482e59004bf0c536422 Author: Karan Bhatia <karandeepb@chromium.org> Date: Mon Feb 12 21:05:07 2018 Extensions: Cache frame data for all frames on creation. Currently, in ExtensionWebContentsObserver::RenderFrameCreated we only cache frame data for extension frames. However, we should do so for all frames. This behavior was (incorrectly) changed in r501291. This CL reverts to old behavior. This should help account for the regression in Extensions.ExtensionFrameMapCacheHit and lead to less hops from the IO to the UI thread and back. BUG= 810614 Change-Id: I2cb66cbf531e01fa40ffb941ca721c7cb62da818 Reviewed-on: https://chromium-review.googlesource.com/910082 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#536186} [modify] https://crrev.com/5c9b088f18a3ea440d166482e59004bf0c536422/chrome/browser/extensions/web_contents_browsertest.cc [add] https://crrev.com/5c9b088f18a3ea440d166482e59004bf0c536422/chrome/test/data/extensions/web_accessible_resources/extension_page.html [add] https://crrev.com/5c9b088f18a3ea440d166482e59004bf0c536422/chrome/test/data/extensions/web_accessible_resources/manifest.json [add] https://crrev.com/5c9b088f18a3ea440d166482e59004bf0c536422/chrome/test/data/extensions/web_accessible_resources/web_accessible_page.html [modify] https://crrev.com/5c9b088f18a3ea440d166482e59004bf0c536422/extensions/browser/extension_api_frame_id_map.cc [modify] https://crrev.com/5c9b088f18a3ea440d166482e59004bf0c536422/extensions/browser/extension_api_frame_id_map.h [modify] https://crrev.com/5c9b088f18a3ea440d166482e59004bf0c536422/extensions/browser/extension_web_contents_observer.cc
,
Feb 12 2018
[Next action] Verify from UMA that this is fixed.
,
Feb 26 2018
The NextAction date has arrived: 2018-02-26
,
Feb 26 2018
From the UMA, it seems that the performance has improved and come back to previous levels - See the spike after Feb 12 Canary- https://uma.googleplex.com/p/chrome/timeline_v2/?sid=39fc2209f681845445f413e8403f047a Dev- https://uma.googleplex.com/p/chrome/timeline_v2/?sid=26e043d6b029b3dfa6c7ad1212e92044 Marking as Fixed. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by karandeepb@chromium.org
, Feb 9 2018