Repro video: https://storage.cloud.google.com/chromiumos-test-logs/bugfiles/cr/810599/IMG-5627.MOV?_ga=2.260590029.-1949964863.1508264737

minch@, you worked on long-press for app icons, any idea on this one? Probably not a regression.

I worked on the long press of shelf icons, don't know too much about the app icons in launcher currently. jennyz@, do you have any idea of this?

Seems that the shelf icons have the same problem, will take a look.

From the video, it looks like the context menu is dismissed after the pen released. Is a stylus pen event treated as a gesture event? You can debug the events in app_list_item_view.cc AppListItemView::OnGestureEvent to take a look to see how the event flow goes with stylus pen touch and release.

If I remember correct, stylus events are piped as TouchEvents. You can then check if it stylus by 

event->pointer_details().pointer_type == ui::EventPointerType::POINTER_TYPE_PEN

This is a regression issue. The long press of stylus works well on M63, but not M64.
culprit cl: 
https://chromium-review.googlesource.com/c/chromium/src/+/759081
Assign to the owner. Please help take a look.

Hm, I need to track down an eve in order to reproduce this myself.

How confident are we that it's https://chromium-review.googlesource.com/c/chromium/src/+/759081 ?

That patch was just cleanup and wasn't expected to have any functional change.

Just finished the bisect between 64.0.3262.0 (good) and 64.0.3265.0 (bad). I guess should have find the correct cl. Let me know if I made something wrong.

Actually, this patch arguably fixes a bug (missing notification of device enablement when palm suppression state changes).

If this patch is the cause then I suspect some other code is handling the notification badly, resulting in the menu being dismissed.

@9 Yes, I looked closer and it is plausible for this to change the behavior.

I don't have an eve, but can you trying reverting the part of the change in InputDeviceFactoryEvdev::EnablePalmSuppression().

If it's fixed with that part reverted, let's undo that change, and figure out what other code the device update notification is tickling that breaks the long press after.

I can reproduce it on caroline and kevin (maybe all the devices that support stylus?).

Makes sense. Can you try reverting the change to InputDeviceFactoryEvdev::EnablePalmSuppression() on any of those devices?

Sure. Will try.

Hi spand@, I tried to revert the change of InputDeviceFactoryEvdev::EnablePalmSuppression() in the cl and it fixed the issue. Does that means we can revert it?

I mean undo the change of InputDeviceFactoryEvdev::EnablePalmSuppression() in the  previous cl.

Yes, please post a patch to revert that part.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f30697974420401bfe6a9205b11b93039f838a36

commit f30697974420401bfe6a9205b11b93039f838a36
Author: MinChen <minch@chromium.org>
Date: Fri Feb 16 23:18:38 2018

ozone: evdev: Partially revert "ozone: evdev: Fix some minor issues and nits"

Since 8a14e9091d96 we dispatch device change notifications when palm suppression
state changes. This is causing context menus to be dismissed erroneously on stylus
lift. It's unclear why this is happening and should be fixed, but for now just
revert to the old behavior.

This is a partial revert of 8a14e9091d96.

Bug:  810599 

Change-Id: Ida6b01f225e35cc7e04b603055a69a25c3f0163d
Reviewed-on: https://chromium-review.googlesource.com/923214
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537452}
[modify] https://crrev.com/f30697974420401bfe6a9205b11b93039f838a36/ui/events/ozone/evdev/input_device_factory_evdev.cc

This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de3185bec46c8c63f4e470b7d976e8f04c3f5442

commit de3185bec46c8c63f4e470b7d976e8f04c3f5442
Author: MinChen <minch@chromium.org>
Date: Tue Feb 20 21:18:14 2018

[Merge to M65]ozone: evdev: Partially revert "ozone: evdev: Fix some minor issues and nits"

TBR=minch@chromium.org

Since 8a14e9091d96 we dispatch device change notifications when palm suppression
state changes. This is causing context menus to be dismissed erroneously on stylus
lift. It's unclear why this is happening and should be fixed, but for now just
revert to the old behavior.

This is a partial revert of 8a14e9091d96.

Bug:  810599 

(cherry picked from commit f30697974420401bfe6a9205b11b93039f838a36)

Change-Id: Ida6b01f225e35cc7e04b603055a69a25c3f0163d
Reviewed-on: https://chromium-review.googlesource.com/923214
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537452}
Reviewed-on: https://chromium-review.googlesource.com/927354
Reviewed-by: min c <minch@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#516}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/de3185bec46c8c63f4e470b7d976e8f04c3f5442/ui/events/ozone/evdev/input_device_factory_evdev.cc

 Issue 817674  has been merged into this issue.

Can we merge this change back to M64?

My Pixelbook and Pen were also adversely affected by this issue on updating to Chrome OS 64 in the stable channel - in that the Pen became generally context-menu-phobic in Tablet Mode (which is where I spend all my time in interacting with my Pixelbook, via a stylus), as documented below.

Let CMPU = Context Menu Pops Up - ie: working as expected from prior good behavior in Chrome OS 62 and 63
Let CMPU&D = Context Menu Pops Up, & then Disappears on pen-up - ie: novel Pen-specific bugged behavior in Chrome OS 64
Let CMFU&DI = on pen-up, Context Menu Flashes Up & Disappears Immediately - ie: novel Pen-specific bugged behavior in Chrome OS 64

Pixelbook Pen-Specific Novel Bugged Behavior in Chrome OS 64
======================================================================================

User Interface ..........................Index........ Capacitive ... Pixelbook
Interaction ............................ Fingertip ... Stylus [1]...  Pen
-------------------------------------------------------------------------------

Long-press on link in Chrome browser ... CMPU ........ CMPU ......... CMPU&D
Long-press on tab in Chrome browser .... CMPU ........ CMPU ......... CMFU&DI
Tap '...' menu in Chrome browser [2] ... CMPU ........ CMPU ......... CMPU&D
Long-press on Shelf app icon ........... CMPU ........ CMPU ......... CMPU&D
======================================================================================
NB: for Chrome OS 62 and 63, the Pixelbook Pen column would also be filled with CMPU from top to bottom.

These novel mis-behaviours of the Pixelbook Pen have become so detrimental to the everyday use of my Pixelbook that I have been forced to use a 'dumb' capacitive stylus instead [1] - and considering that I paid £99 for my 'smart' Pixelbook Pen, it's intensely annoying that the Chrome OS Development Team's months-long quality control process, from alpha to beta to stable, FAILED to identify that a purported "bug fix" actually *DEGRADED* the use of the Pixelbook Pen - to the point where, in my case, it has been forced out of common usage.

Still, it's good to see that the miscreant culprit code has been identified, and a remedial patch has been created for Chrome OS 65, for which all involved have my gratitude.

I've recently installed a Chrome OS 64 stable channel incremental OS update, which only updated the Flash player - and it's good to know that such incremental OS updates are a part of Chrome OS development culture. So I want to add my support to minch's 'Merge-Request-64', such that the remedial patch to restore CORRECT stylus functionality be rolled out as an incremental OS update as soon as possible, as a remedy to all adversely affected owners of pen-equipped Chromebooks - ie: Samsung Chromebook Plus (kevin), Samsung Chromebook Pro (caroline), Google Pixelbook (eve), and most likely the Lenovo 500e, too.

Footnotes

[1] My 'Capacitive Stylus' is this one » https://www.amazon.co.uk/gp/product/B00V7RKTBK

[2] Tap '...' menu in Chrome browser: for instance, in Chrome browser, long-press on a word in a webpage to show the [ Copy | ... ] pop-up context menu, then tap on the '...' to see the 'Other Actions' context submenu

Verified on ChromeOS 10452.96.0, 66.0.3359.181 stable-channel