Indirect-leak in mojo::internal::InterfacePtrState<ukm::mojom::UkmRecorderInterface>::ConfigurePr |
|||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=4829563117633536 Fuzzer: ifratric-browserfuzzer-v3 Job Type: linux_lsan_chrome_mp Platform Id: linux Crash Type: Indirect-leak Crash Address: Crash State: mojo::internal::InterfacePtrState<ukm::mojom::UkmRecorderInterface>::ConfigurePr instance get Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=209699:209703 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4829563117633536 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Feb 12 2018
Looks like ukm_recorder_ may be leaking on Document. Not sure if this should really matter assuming it's only a renderer shutdown leak? +CC holte as the last person to change blink::Document::UkmRecorder().
,
Feb 16 2018
ClusterFuzz has detected this issue as fixed in range 537181:537198. Detailed report: https://clusterfuzz.com/testcase?key=4829563117633536 Fuzzer: ifratric-browserfuzzer-v3 Job Type: linux_lsan_chrome_mp Platform Id: linux Crash Type: Indirect-leak Crash Address: Crash State: mojo::internal::InterfacePtrState<ukm::mojom::UkmRecorderInterface>::ConfigurePr instance get Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=209699:209703 Fixed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=537181:537198 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4829563117633536 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Feb 16 2018
ClusterFuzz testcase 4829563117633536 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Feb 16 2018
Since the ukm_recorder_ is held in a unique_ptr, is this a case where the Document object itself is leaked?
,
Feb 21 2018
Issue 813409 has been merged into this issue.
,
Feb 21 2018
Re-opening this because it's appearing again (see issue 813409 ). I agree with #5 that it looks like a Document leak.
,
Feb 23 2018
Issue 814980 has been merged into this issue.
,
Feb 23 2018
+hajimehoshi, since one of the reasons that UKM recorder exists on Document is to help identify causes of document leaks per https://bugs.chromium.org/p/chromium/issues/detail?id=757374
,
Mar 15 2018
This crash occurs very frequently on linux platform and is likely preventing the fuzzer ifratric-browserfuzzer-v3 from making much progress. Fixing this will allow more bugs to be found. Marking this bug as a blocker for next Beta release. If this is incorrect, please add ClusterFuzz-Wrong label and remove the ReleaseBlock-Beta label.
,
Mar 26 2018
Friendly ping to get an update on this issue as it is marked as beta blocker. Thanks..!
,
Mar 28 2018
A friendly reminder that M67 branch is coming soon on 04/12! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP to trunk. This way we branch M67 from a high quality trunk. Thank you.
,
Mar 28 2018
Issue 821363 has been merged into this issue.
,
Mar 28 2018
This is not a Mojo bug, so removing that component. The report implies that a UkmRecorderInterface endpoint is leaking. See comments #7 and #9 for more context.
,
Mar 28 2018
Automatically applying components based on crash stacktrace and information from OWNERS files. If this is incorrect, please apply the Test-Predator-Wrong-Components label.
,
Mar 28 2018
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/62d0093b891fa483449513db827aee7b36760e0c (MD Extensions: eliminate lags when clicking between errors in the error console.). If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
,
Mar 28 2018
,
Apr 2 2018
A friendly reminder that M67 branch is coming soon on 04/12! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP to trunk. This way we branch M67 from a high quality trunk. Thank you.
,
Apr 10 2018
Gentle ping to get an update on this issue as it is marked as beta blocker fro M67 & M67 branch is coming soon on 04/12 Thanks..!
,
Apr 10 2018
I don't know how to fix the Document leak here, but we could potentially avoid leaking the UkmRecorderInterface object around when that happens, either by: * By not holding onto the UkmRecorderInterface and creating new ones from connector as needed. * By keeping a single shared UkmRecorderInterface somewhere (maybe Platform?) Given that other objects must be being leaked here I'm not sure what severity of leaking UkmRecorderInterface is.
,
Apr 11 2018
A friendly reminder that M67 branch is tomorrow, Thursday 04/12! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP to trunk. This way we branch M67 from a high quality trunk. Thank you.
,
Apr 11 2018
Removing ReleaseBlock-Beta since it doesn't seem like this is severe enough to warrant it. My understanding is that: * This occurs when a Document leaks * Document leaks in general are not a new issue. * This extra object being leaked is only adding a couple bytes to that existing leak.
,
Apr 12 2018
+yuzus, keishi who are looking at document leaks
,
Apr 20 2018
Please assign this to a more applicable owner.
,
Apr 23 2018
Issue 835022 has been merged into this issue.
,
Oct 17
,
Oct 26
This issue has been fixed. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by brajkumar@chromium.org
, Feb 9 2018Components: Internals>Mojo
Labels: M-64 Test-Predator-Wrong CF-NeedsTriage