New issue
Advanced search Search tips

Issue 810594 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 728805



Sign in to add a comment

Remove --disable-md-oobe command-line switch.

Project Member Reported by alemate@chromium.org, Feb 9 2018

Issue description

--disable-md-oobe command-line option is outdated and should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8dbd10b46963d4658900cbd5e05d005d4731ab4

commit c8dbd10b46963d4658900cbd5e05d005d4731ab4
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Feb 09 01:43:06 2018

Chrome OS: Remove --disable-md-oobe command-line option.

Bug: 728805, 810594 
Change-Id: I759cd54222c4fcf2cac5fe6032e8c12bd4a3bb38
Reviewed-on: https://chromium-review.googlesource.com/910317
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535615}
[modify] https://crrev.com/c8dbd10b46963d4658900cbd5e05d005d4731ab4/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/c8dbd10b46963d4658900cbd5e05d005d4731ab4/chromeos/chromeos_switches.cc
[modify] https://crrev.com/c8dbd10b46963d4658900cbd5e05d005d4731ab4/chromeos/chromeos_switches.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867

commit b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Feb 09 02:34:57 2018

Revert "Chrome OS: Remove --disable-md-oobe command-line option."

This reverts commit c8dbd10b46963d4658900cbd5e05d005d4731ab4.

Reason for revert: Screen is needed on ToT.

Original change's description:
> Chrome OS: Remove --disable-md-oobe command-line option.
> 
> Bug: 728805, 810594 
> Change-Id: I759cd54222c4fcf2cac5fe6032e8c12bd4a3bb38
> Reviewed-on: https://chromium-review.googlesource.com/910317
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Commit-Queue: Alexander Alekseev <alemate@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#535615}

TBR=stevenjb@chromium.org,achuith@chromium.org,alemate@chromium.org

Change-Id: I76fa4d99f9140ae4df139557cfcb4264ec8e0251
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 728805,  810594 
Reviewed-on: https://chromium-review.googlesource.com/910045
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535616}
[modify] https://crrev.com/b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867/chromeos/chromeos_switches.cc
[modify] https://crrev.com/b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867/chromeos/chromeos_switches.h

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1587beaa62e07d1575de51f33f8ddb2f13ea6c0

commit f1587beaa62e07d1575de51f33f8ddb2f13ea6c0
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Feb 09 02:35:53 2018

Revert "Revert "Chrome OS: Remove --disable-md-oobe command-line option.""

This reverts commit b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867.

Reason for revert: Incorrect revert.

Original change's description:
> Revert "Chrome OS: Remove --disable-md-oobe command-line option."
> 
> This reverts commit c8dbd10b46963d4658900cbd5e05d005d4731ab4.
> 
> Reason for revert: Screen is needed on ToT.
> 
> Original change's description:
> > Chrome OS: Remove --disable-md-oobe command-line option.
> > 
> > Bug: 728805, 810594 
> > Change-Id: I759cd54222c4fcf2cac5fe6032e8c12bd4a3bb38
> > Reviewed-on: https://chromium-review.googlesource.com/910317
> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> > Commit-Queue: Alexander Alekseev <alemate@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#535615}
> 
> TBR=stevenjb@chromium.org,achuith@chromium.org,alemate@chromium.org
> 
> Change-Id: I76fa4d99f9140ae4df139557cfcb4264ec8e0251
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 728805,  810594 
> Reviewed-on: https://chromium-review.googlesource.com/910045
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Commit-Queue: Alexander Alekseev <alemate@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#535616}

TBR=stevenjb@chromium.org,achuith@chromium.org,alemate@chromium.org

Change-Id: Ie979d28089e457af300e86c7a7caaa870c03e297
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 728805,  810594 
Reviewed-on: https://chromium-review.googlesource.com/910046
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535617}
[modify] https://crrev.com/f1587beaa62e07d1575de51f33f8ddb2f13ea6c0/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/f1587beaa62e07d1575de51f33f8ddb2f13ea6c0/chromeos/chromeos_switches.cc
[modify] https://crrev.com/f1587beaa62e07d1575de51f33f8ddb2f13ea6c0/chromeos/chromeos_switches.h

Labels: -M-65 M-66

Sign in to add a comment