Tab-to-search prefers typed keyword over inline-autocompleted one |
|||
Issue descriptionPrerequisite: two keywords, one of which is a prefix of the other, and history such that typing the prefix will inline-autocomplete to the longer keyword. For example, on my work profile, I have the keywords "b" and "beeradvocate.com", and typing the letter 'b' inline-autocompletes to "beeradvocate.com". In this situation, if I type 'b' and press <tab>, I enter keyword mode for "b" instead of "beeradvocate.com". This feels surprising, since I was reading the inline autocompletion to decide what to expect. I would have assumed 'b' followed by <space> would, in fact, trigger the "b" keyword; so this is a case where <tab> and <space> would ideally (IMO) accept different keywords. I believe we may have done this intentionally originally, on the grounds that we didn't want new inline autocompletions to break longstanding keywords. But it feels too weird.
,
Feb 9 2018
It's intentional (I proposed it), but I'm reasonably convinced I was wrong by virtue of it feeling so awful in a non-hypothetical situation :). The distinction between which keyword tab vs. space would trigger should still let people access short keywords in the face of bad autocompletions, although it's not terribly discoverable. The idea of disabling autocompletion when we'd autocomplete away from an exact keyword, as in comment 7 on that bug, seems like a better fix to this -- it's what we basically do for history navigations, where if you type an exact match to a history entry, we avoid inline-autocompleting to something longer.
,
Feb 13 2018
,
Feb 13 2018
I'd prefer a solution that distinguishes between tab and space, not a solution that disables inline autocompletion. Disabling inline autocompletion is too heavy-handed to solve this and the earlier complaints. The complaints are about entering keyword mode (which keyword gets entered when), not saying that the original inline autocompletion was wrong.
,
Feb 13 2018
In some sense, though, the inline autocompletion _is_ wrong -- if you intended to trigger the short keyword, and Chrome is autocompleting to the long one, it's not doing what you want. We can't really handwave that away by saying that the inline autocompletion is only about navigations and not relevant to triggering keyword mode, because it's really for both. So yeah, I'm complaining that I shouldn't have been autocompleted to a long thing in the first place when I typed an exact shorter keyword :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by mpear...@chromium.org
, Feb 9 2018