New issue
Advanced search Search tips

Issue 810567 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 702866
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

<esc> from inside keyword mode cancels editing

Project Member Reported by pkasting@chromium.org, Feb 8 2018

Issue description

Type something that produces omnibox dropdown entries with associated keywords (ideally not in the top slot, since it's more obvious this behavior is wrong when the first keyword is in the second slot).

Tab until you're inside one of the keyword entries.  Hit esc.

Expected: Revert to the original typed text with top line selected, just like what happens if you tab down to a row that doesn't have a keyword.

Actual: Editing is cancelled entirely.

I suspect this is because while in keyword mode the user text is empty, and we treat esc-on-empty-user-text as "bail out of edits" without realizing that we're really more in the "temporary text" case.  This may be tangentially related to bug 736931.
 
Mergedinto: 702866
Status: Duplicate (was: Untriaged)

Sign in to add a comment