New issue
Advanced search Search tips

Issue 810544 link

Starred by 1 user
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Don't composite "trivial" 3D transforms on low-end Android devices

Project Member Reported by chrishtr@chromium.org, Feb 8 2018 
See also internal issue 72559941.

translateZ(0) and similar constructs currently trigger composited layers.
Sites do this on purpose to isolate raster and paint costs and improve
caching. However, the memory and per-composited-layer overhead
costs on low-end Android devices likely outweigh the desire to
composite on behalf of developers.

Note that compositing is not required for correctness in this case-
 it's a pure performance tradeoff.

Will watch performance metrics after this change to see its impact.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/812a74e7bc08bf89f8d8dd6b2260492e4bc318b7

commit 812a74e7bc08bf89f8d8dd6b2260492e4bc318b7
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri Feb 09 01:37:01 2018

Don't composite trivial 3D on low-end devices.

Bug:  810544 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ieec17582540cf79f4f73bc4221226dbdbf20c2d3
Reviewed-on: https://chromium-review.googlesource.com/909951
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535611}
[modify] https://crrev.com/812a74e7bc08bf89f8d8dd6b2260492e4bc318b7/third_party/WebKit/Source/core/paint/compositing/CompositingReasonFinder.cpp
[modify] https://crrev.com/812a74e7bc08bf89f8d8dd6b2260492e4bc318b7/third_party/WebKit/Source/core/paint/compositing/CompositingReasonFinderTest.cpp
[modify] https://crrev.com/812a74e7bc08bf89f8d8dd6b2260492e4bc318b7/third_party/WebKit/Source/platform/transforms/ScaleTransformOperation.h
[modify] https://crrev.com/812a74e7bc08bf89f8d8dd6b2260492e4bc318b7/third_party/WebKit/Source/platform/transforms/TransformOperation.h
[modify] https://crrev.com/812a74e7bc08bf89f8d8dd6b2260492e4bc318b7/third_party/WebKit/Source/platform/transforms/TransformOperations.h
[modify] https://crrev.com/812a74e7bc08bf89f8d8dd6b2260492e4bc318b7/third_party/WebKit/Source/platform/transforms/TranslateTransformOperation.h

Comment 2 by chrishtr@chromium.org, Mar 3 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment