chromeos-4.14: Builds with DRM_I915_GVT enabled are broken |
|||||
Issue description
drivers/gpu/drm/i915/gvt/handlers.c: In function 'mmio_read_from_hw':
drivers/gpu/drm/i915/gvt/handlers.c:1440:2: error: implicit declaration of function 'intel_gvt_render_mmio_to_ring_id'
intel_gvt_render_mmio_to_ring_id() is not available in chromeos-4.14.
Caused by commit ddd27534d9eb0 ("UPSTREAM: drm/i915/gvt: Limit read
hw reg to active vgpu").
,
Feb 8 2018
This was me - I'm on it.
,
Feb 8 2018
Per #2, should be assigned to Nathan, which isn't possible for some reason. Marking as Available instead. Alternative is to mark the driver as BROKEN, as per CL:909800. I don't mind to wait if this gets fixed soon. However, it affects my ability to test stable release merges, so if the fix is difficult please approve CL:909800 and re-enable the driver after the fix is available.
,
Feb 8 2018
,
Feb 8 2018
Alright, this was a missing dependency, mistake on my part in the cnl_i915_forklift_3 series that merged yesterday. This CL:909991 should fix it. I tested building arm, arm64, and x86_64 allmodconfig. P.S: I'm unable to assign this bug to myself.
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b9014010a4ab69e5bff6d09f1b60bac2ec164828 commit b9014010a4ab69e5bff6d09f1b60bac2ec164828 Author: Zhi Wang <zhi.a.wang@intel.com> Date: Fri Feb 09 10:19:56 2018 UPSTREAM: drm/i915/gvt: Export intel_gvt_render_mmio_to_ring_id() Since many emulation logic needs to convert the offset of ring registers into ring id, we export it for other caller which might need it. Signed-off-by: Zhi Wang <zhi.a.wang@intel.com> (cherry picked from commit 62a6a53786fc4b4e7543cc63b704dbb3f7df4c0f) (cherry picked from commit 365ad5df9caa1a7ebc73b8d70ab94bbf6a74268a) Fixes: Change-Id:Iefc1bbe45cb "UPSTREAM: drm/i915/gvt: Limit read hw reg to active vgpu" BUG=chromium:783394, chromium:810530 TEST='make allmodconfig' successful and device boots to graphics Change-Id: I906a02bb7c33c7f5066536309b4ac90450834416 Signed-off-by: Nathan Ciobanu <nathan.d.ciobanu@intel.com> Reviewed-on: https://chromium-review.googlesource.com/909991 Commit-Ready: Guenter Roeck <groeck@chromium.org> Tested-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> [modify] https://crrev.com/b9014010a4ab69e5bff6d09f1b60bac2ec164828/drivers/gpu/drm/i915/gvt/mmio.h [modify] https://crrev.com/b9014010a4ab69e5bff6d09f1b60bac2ec164828/drivers/gpu/drm/i915/gvt/handlers.c
,
Feb 9 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by groeck@chromium.org
, Feb 8 2018