New issue
Advanced search Search tips

Issue 810527 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

cros deploy doesn't like ipv6 remotes

Project Member Reported by bleung@chromium.org, Feb 8 2018

Issue description

(cr) ((78d28d9...)) bleung@bleung-glaptop2 ~/trunk/src/scripts $ cros deploy 2620:0:yadda:yadda:yadda:yadda:yadda:yadda wireshark
04:44:26: ERROR: Unknown device scheme "2620" in "2620:0:yadda:yadda:yadda:yadda:yadda:yadda"
usage: cros deploy [-h]
                   [--log-level {fatal,critical,error,warning,notice,info,debug}]
                   [--log_format LOG_FORMAT] [--debug] [--nocolor]
                   [--board BOARD] [--no-strip] [--unmerge] [--root ROOT]
                   [--no-clean-binpkg] [--emerge-args EMERGE_ARGS]
                   [--private-key PRIVATE_KEY] [--no-ping] [--dry-run]
                   [--force] [--update] [--deep] [--deep-rev]
                   device packages [packages ...]
cros deploy: error: argument device: invalid DeviceParser value: '2620:0:yadda:yadda:yadda:yadda:yadda:yadda'


 
Status: WontFix (was: Untriaged)
IPv6 addresses need to be bracketed like other tools, otherwise there's no way to disambiguate the address in URIs (which is what "device" is here).  what is a scheme ?  what is a port ?  what is the host ?

if '[2620:0:yadda:yadda:yadda:yadda:yadda:yadda]' doesn't work, then please re-open
:headslap: You're absolutely right. Thanks Mike!
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7163c3ae4f6e0dacbe6da6f8c4da6f39c835ec2b

commit 7163c3ae4f6e0dacbe6da6f8c4da6f39c835ec2b
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Feb 17 02:48:04 2018

cli.command: clarify IPv4/IPv6 syntax

BUG= chromium:810527 
TEST=`cros deploy --help` done been read

Change-Id: Ie18cc8aaab162e05b73e73649c5fdbf5c90c7ec7
Reviewed-on: https://chromium-review.googlesource.com/909657
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>

[modify] https://crrev.com/7163c3ae4f6e0dacbe6da6f8c4da6f39c835ec2b/cli/command.py

Sign in to add a comment