New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810525 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Ports in Extensions Match Patterns need help

Project Member Reported by rdevlin....@chromium.org, Feb 8 2018

Issue description

Match Patterns (https://developer.chrome.com/extensions/match_patterns) are implemented in the codebase as URLPatterns.  URLPatterns support ports.  However, they need a bit of help.

- Parsing fails for certain patterns that seem like they should succeed.  e.g. "http://*:80/*" (match any http host on port 80) fails to parse.
- Parsing doesn't allow ports with a wildcard scheme, even though the wildcard scheme deduces to http | https - both of which support ports.
- The documentation actually makes no mention of ports being supported.

I probably won't get to this at any point in the near future, and don't consider it pressing, but it would be nice to eventually fix.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ab1294c92dfab538b185f0f25f44f6491a49759

commit 0ab1294c92dfab538b185f0f25f44f6491a49759
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Feb 23 01:37:35 2018

[Extensions] Fix URLPattern Port Parsing

Fix URLPattern parsing when a port is present to ensure that a host is
provided. Also optimize a bit to avoid a few additional string copies.

Bug:  812543 , 810525

Change-Id: I209bf3f0dac37ce4d774e8bbb89fb7712284c6bc
Reviewed-on: https://chromium-review.googlesource.com/930000
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538657}
[modify] https://crrev.com/0ab1294c92dfab538b185f0f25f44f6491a49759/extensions/common/url_pattern.cc
[modify] https://crrev.com/0ab1294c92dfab538b185f0f25f44f6491a49759/extensions/common/url_pattern_unittest.cc

Sign in to add a comment