New issue
Advanced search Search tips

Issue 810503 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: System UI shows up briefly entering VR on headset insertion for CTA.

Project Member Reported by mthiesse@chromium.org, Feb 8 2018

Issue description

The system UI also shows up for CCTs, but that's problems unsolvable (at least on N/O).

For CTA, since they're singleInstance activities we can special case them avoid the CCT workarounds that lead the system UI to show up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57ae8192495092a13d496038dbe71fdfabaab061

commit 57ae8192495092a13d496038dbe71fdfabaab061
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Thu Feb 08 21:32:44 2018

VR: Special case launching CTA in VR to avoid system UI showing up.

The moveTaskToFront solution we need to support webVR in CCTs doesn't
need to be used for CTA, so we can instead use launchInVr and avoid
animations that lead to the preview window being shown.

Bug:  810503 
Change-Id: I721bc5b703a1940e6ef83b8c79f47f4e762d9185
Reviewed-on: https://chromium-review.googlesource.com/909649
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535525}
[modify] https://crrev.com/57ae8192495092a13d496038dbe71fdfabaab061/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java
[modify] https://crrev.com/57ae8192495092a13d496038dbe71fdfabaab061/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
[modify] https://crrev.com/57ae8192495092a13d496038dbe71fdfabaab061/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/57ae8192495092a13d496038dbe71fdfabaab061/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/mock/MockVrDaydreamApi.java

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f090bc3ed93b6b937fb65b9545985106355d179

commit 7f090bc3ed93b6b937fb65b9545985106355d179
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Feb 09 22:12:58 2018

VR: Fix system UI not restoring correctly when exiting VR.

On headset insertion with VrShellDelegate already created we erroneously
set the window mode before calling setWindowMode(), leading us to
incorrectly restore the system UI.

Bug:  810503 
Change-Id: I7da112f5a1041dcff596e244e60d655fb3e66c33
Reviewed-on: https://chromium-review.googlesource.com/911831
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535848}
[modify] https://crrev.com/7f090bc3ed93b6b937fb65b9545985106355d179/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Labels: Test-Complete

Sign in to add a comment