New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Clear MEI data

Project Member Reported by mlamouri@chromium.org, Feb 8 2018

Issue description

We should clear MEI data in M65 in order to start from scratch and wipe the consequences of miscounting pre-fetched/rendered tabs.

I believe we should merge this to M65 even if we are late in the cycle because it will allow most users to have a larger data set when the feature launch and will allow us to better compare the MEI score changes based on turning on autoplay restrictions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1616ebb8ff5b208cb91e6c6888f628b920fe728

commit a1616ebb8ff5b208cb91e6c6888f628b920fe728
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Fri Feb 09 13:29:40 2018

Media Engagement: increase schema version.

This will trigger all local Media Engagement data to be wiped
in order to start from scratch and remove the impact of some
bugs that have been recently cleared.

Bug:  810501 
Change-Id: I142ad738b32d787387f1b19a84fcf151fc67b569
Reviewed-on: https://chromium-review.googlesource.com/909489
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535696}
[modify] https://crrev.com/a1616ebb8ff5b208cb91e6c6888f628b920fe728/chrome/browser/media/media_engagement_service.cc

Labels: Merge-Request-65
This is the last Merge-Request for MEI. Now that the fixes for data collection have been merged into M65, we would like to clear the database in M65. This should be very low risk as we did this in the past and the pipeline is activated by an update is DB schema version.

The benefit for us is to be able to build a preload list based on the data collected on M65 users and for this we would like to clear out the data that had bugs.
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 12 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Feb 12 2018

Labels: -Merge-Review-65 Merge-Approved-65
Approving merge to M65 branch 3325 based on comment #2. Please merge ASAP. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 12 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74abf2607741293fb24a2322cfae9bc69f221fac

commit 74abf2607741293fb24a2322cfae9bc69f221fac
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Feb 12 16:38:02 2018

Media Engagement: increase schema version.

This will trigger all local Media Engagement data to be wiped
in order to start from scratch and remove the impact of some
bugs that have been recently cleared.

Bug:  810501 
Change-Id: I142ad738b32d787387f1b19a84fcf151fc67b569
Reviewed-on: https://chromium-review.googlesource.com/909489
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535696}(cherry picked from commit a1616ebb8ff5b208cb91e6c6888f628b920fe728)
Reviewed-on: https://chromium-review.googlesource.com/913619
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#425}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/74abf2607741293fb24a2322cfae9bc69f221fac/chrome/browser/media/media_engagement_service.cc

Status: Fixed (was: Started)

Sign in to add a comment