New issue
Advanced search Search tips

Issue 810461 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Minimized windows in overview not stacked properly.

Project Member Reported by sammiequon@chromium.org, Feb 8 2018

Issue description

(1) Open 3 windows and minimize all 3.
(2) Enter tablet mode, then overview mode.
(3) Drag the first window over the other 2.

Expected:
Window is seen on top of the other windows while dragged.

Actual:
Window is underneath.


 
Also if one of the 3 windows is not snappable, and a window is snapped. The "App does not support split-screen" does not appear until that window is attempted to dragged.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/306c040b2263619e7efe15fa66226b0551525244

commit 306c040b2263619e7efe15fa66226b0551525244
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Feb 14 02:11:48 2018

overview: Minimized window items not stacked properly.

Window items which are based on minimized windows have some issues.
The "App does not support split-screen" label does not show up, and
dragged windows are not always on top of the rest of the window items.

The current logic always stacks the window item widget on top of the
original window. But the original window is actually below the minimized
widget on z order, so the item widget ends up also being below. The
minimized widget needs to be stacked below, or the item widget needs to
be stacked above the minimized widget. This CL attempts the latter.

Also cache the command line flag for new overview ui, to reduce the
amount of calls.

Also center the "App does not support split-screen" label in the window
selector item minus the title bar.

Test: manual
Bug:  810461 
Change-Id: I1bd10fe0d206b175112d33a359775c13a5b9e19e
Reviewed-on: https://chromium-review.googlesource.com/909301
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima (In Tokyo) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536608}
[modify] https://crrev.com/306c040b2263619e7efe15fa66226b0551525244/ash/wm/overview/overview_utils.cc
[modify] https://crrev.com/306c040b2263619e7efe15fa66226b0551525244/ash/wm/overview/overview_utils.h
[modify] https://crrev.com/306c040b2263619e7efe15fa66226b0551525244/ash/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/306c040b2263619e7efe15fa66226b0551525244/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/306c040b2263619e7efe15fa66226b0551525244/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/306c040b2263619e7efe15fa66226b0551525244/ash/wm/overview/window_selector_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment