Loading install attributes on linux chrome_os build is broken |
|||
Issue descriptionProblem: BrowserPolicyConnectorChromeOS is created[1] before Chrome overrides[2] path to stub files. So it tries to load wrong file with the install attributes. Regression CL is: https://chromium-review.googlesource.com/c/chromium/src/+/898070 [1] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc?q=connector_chromeos&dr=C&l=107 [2] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/chrome_browser_main_chromeos.cc?type=cs&sq=package:chromium&l=632 What steps will reproduce the problem? (1) Enroll "device" into managed domain. (2) Restart chrome What is the expected result? UI should show that device is managed What happens instead? UI is normal for normal customer user
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09fdc041bdeb2ea37f12c703705d4b19e1b6440b commit 09fdc041bdeb2ea37f12c703705d4b19e1b6440b Author: Scott Violet <sky@chromium.org> Date: Fri Feb 09 22:02:14 2018 chromeos: Fix regression in overring policy paths The path overrides need to occur before BrowserPolicyConnectorChromeOS is created, otherwise they do nothing. This moves the code to right before BrowserPolicyConnectorChromeOS is created to ensure that happens. Also adds a DCHECK. BUG= 810434 TEST=none Change-Id: I5191e2af4c74ce03744a20d3af67d6ea617ab74d Reviewed-on: https://chromium-review.googlesource.com/909948 Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#535842} [modify] https://crrev.com/09fdc041bdeb2ea37f12c703705d4b19e1b6440b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
,
Feb 9 2018
,
Apr 11 2018
Marked this as "Verified" because during Full Release M-65/M-66 testing this issue has not been reproduced. |
|||
►
Sign in to add a comment |
|||
Comment 1 by sky@chromium.org
, Feb 8 2018