New issue
Advanced search Search tips

Issue 810432 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 161072



Sign in to add a comment

Web Locks API: Rename acquire() to request()

Project Member Reported by jsb...@chromium.org, Feb 8 2018

Issue description

Per W3C TAG feedback, request() would be more consistent with other lock APIs in the platform.

 
Blocking: 161072
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdee99cf89574ce9f7a849dea3168bff493c993d

commit cdee99cf89574ce9f7a849dea3168bff493c993d
Author: Joshua Bell <jsbell@chromium.org>
Date: Thu Feb 08 21:43:54 2018

Web Locks API: Rename method from acquire() to request()

Per feedback from the W3C TAG, rename the method to get a lock from
acquire() to request(). This makes sense, as the lock is not acquired
until the method succeeds. This is also more consistent with other
locking APIs in the platform.

https://github.com/inexorabletash/web-locks/issues/35

Bug:  810432 

Change-Id: I6c30c83167a25cdf6ca982f03d399e9ff5274b52
Reviewed-on: https://chromium-review.googlesource.com/907682
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535530}
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/acquire.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/chromium-waiting-promise-gc.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/frames.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/held.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/ifAvailable.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/interfaces.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/interfaces.idl
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/lock-attributes.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/mode-exclusive.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/mode-mixed.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/mode-shared.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/opaque-origin.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/query-order.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/query.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/resource-names.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/resources/iframe.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/resources/interfaces-worker.js
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/resources/worker.js
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/signal.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/steal.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/locks/workers.html
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/Source/modules/locks/LockManager.cpp
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/Source/modules/locks/LockManager.h
[modify] https://crrev.com/cdee99cf89574ce9f7a849dea3168bff493c993d/third_party/WebKit/Source/modules/locks/LockManager.idl

Status: Fixed (was: Started)
Oops - I forgot to rename the acquire.html test. :P

Sign in to add a comment