New issue
Advanced search Search tips

Issue 810431 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
M-X



Sign in to add a comment

[MacViews] Text fields don't support multiple lines

Project Member Reported by sdy@chromium.org, Feb 8 2018

Issue description

Chrome Version: 66.0.3342.0
OS: macOS 10.13.3

What steps will reproduce the problem?
(1) Visit this URL: data:text/html,<script>prompt()</script>
(2) Either paste a string with newlines, or use opt+enter to type a newline.

What is the expected result?
Newlines are preserved, or inserted.

What happens instead?
Newlines in a pasted string become spaces. Typed newlines aren't inserted.
 
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
All you :)

Comment 2 by sdy@chromium.org, Mar 19 2018

Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)
After our 1:1, I'm un-assigning this from myself. I still have interest in fixing it, but I think it makes sense for it to be available. Feel free to reassign it to me if that wasn't right.
Labels: M-X
MacViews triage: marking this as M-X, since we have no concrete plans right now to work on this.
Owner: tnijssen@google.com

Comment 5 by tnijssen@google.com, May 26 2018

I have a few questions regarding this bug:
1.) Should new lines only be added in certain textfields? For example, should the insertion of new lines be supported in the omnibox?
2.) What should be the textfield's behavior to deal with the new line? Should it become bigger or still only show one line of text?
Status: Assigned (was: Available)
For (1): I think we should support this on views::Textfield but have this disabled by default, and have a setter (something like SetMultiLine) that lets individual Textfields opt into multiline behavior.

For (2): They should retain their usual height, but the up/down arrow keys should navigate between lines. Try the sample given in the OP in Safari for an example of this behavior.
Labels: Group-Views_Regressions_from_Cocoa
Cc: -ellyjo...@chromium.org
Owner: ellyjo...@chromium.org
I got started on this bug (see crrev/c/1077371) but I don't think I'm going to be able to do all the associated work to get this working before I leave, so I'm kicking this back.
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
*** Mass UI Triage *** 

Able to reproduce this issue with Chrome #72
Owner: robliao@chromium.org
Mac triage: to robliao@ for Views triage.
Labels: Hotlist-DesktopUIConsider
Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged

Sign in to add a comment