New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 810429 link

Starred by 1 user
Status: Duplicate
Merged: issue 694880
Owner:
falken@chromium.org
Closed: Feb 2018
Cc:
█ bmcquade@chromium.org
nhiroki@chromium.org
rbyers@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Service Worker push notification is causing UseCounter to record PageVisits

Project Member Reported by loonyb...@chromium.org, Feb 8 2018 
I've noticed that "https://www.facebook.com/sw?s=push" is being counted towards UseCounter kPageVisits (caller: Page::DidCommitLoad). 

This shouldn't happen. 

What is the right way to distinguish SW push notification Pages from other Pages?

Comment 1 by loonyb...@chromium.org, Feb 8 2018

Cc: falken@chromium.org nhiroki@chromium.org

Comment 2 by e...@chromium.org, Feb 8 2018

Components: -Blink

Comment 3 by loonyb...@chromium.org, Feb 8 2018

Summary: Service Worker push notification is causing UseCounter to record PageVisits (was: Service Worker push notification is causing UseCounter to record PageVitists)

Comment 4 by loonyb...@chromium.org, Feb 8 2018 

Somehow I only managed to reproduce this bug on non-incognito mode (with no extensions). In incognito mode, I do not observe this behaviour.

Comment 5 by shimazu@chromium.org, Feb 9 2018

Cc: -falken@chromium.org
Owner: falken@chromium.org
Blink-worker bug triaging. 
falken@, could you triage this?

Comment 6 by nhiroki@chromium.org, Feb 9 2018

Mergedinto: 694880
Status: Duplicate (was: Untriaged)
Service Worker has the "shadow page" mechanism[1] for loading resources and it unfavorably counts page load on every Service Worker startup. See  issue 694880 .

[1] https://chromium.googlesource.com/chromium/src/+/ce1dbb2de90624ef7594b144c1a0f0ba2e3b226b/third_party/WebKit/Source/core/exported/WorkerShadowPage.h#21

Comment 7 by falken@chromium.org, Feb 9 2018 

By the way, I think push is disabled in incognito mode, which could explain c#4.
►

Sign in to add a comment