New issue
Advanced search Search tips

Issue 810420 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Remove old experience-sampling API

Project Member Reported by cthomp@chromium.org, Feb 8 2018

Issue description

The private Experience Sampling extension API (launched in issue 384635) is no longer being used. We plan to deprecate and remove it. Since it was a private API used by only one extension, there should be no compatibility risk (and no need for a visible deprecation period).

Assigning this task to myself to make sure it is in my queue.
 

Comment 1 by cthomp@chromium.org, Feb 13 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b286c96592958096a8c238f02e01052fb4085c4

commit 8b286c96592958096a8c238f02e01052fb4085c4
Author: Christopher Thompson <cthomp@chromium.org>
Date: Fri Feb 16 19:08:25 2018

Remove and deprecate ExperienceSamplingPrivate API

This removes the ExperienceSamplingPrivate extension API, which was used
only by the CUES extension (which is no longer in use). This also
removes all the instrumentation code that triggered the extension events
throughout the code base, and deprecates entries in enums.

Bug:  810420 
Change-Id: Ia155ad3feada4bac147f0960e05065c44d6978a3
Reviewed-on: https://chromium-review.googlesource.com/915121
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537369}
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/app/generated_resources.grd
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/extensions/BUILD.gn
[delete] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/chrome/browser/extensions/api/experience_sampling_private/OWNERS
[delete] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
[delete] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h
[delete] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.cc
[delete] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.h
[delete] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api_unittest.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/extensions/extension_install_prompt.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/extensions/extension_install_prompt.h
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/interstitials/chrome_metrics_helper.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/interstitials/chrome_metrics_helper.h
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ssl/bad_clock_blocking_page.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ssl/captive_portal_blocking_page.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ssl/mitm_software_blocking_page.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ssl/ssl_blocking_page.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ssl/ssl_error_tab_helper_unittest.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ui/cocoa/download/download_item_controller.h
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ui/cocoa/download/download_item_controller.mm
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ui/views/download/download_danger_prompt_views.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ui/views/download/download_item_view.h
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/browser/ui/views/extensions/extension_install_dialog_view.h
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/common/extensions/api/_permission_features.json
[delete] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/chrome/common/extensions/api/experience_sampling_private.json
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/common/extensions/permissions/chrome_permission_message_rules.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/chrome/test/BUILD.gn
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/components/security_interstitials/core/metrics_helper.cc
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/8b286c96592958096a8c238f02e01052fb4085c4/tools/metrics/histograms/enums.xml

Comment 3 by cthomp@chromium.org, Feb 16 2018

Status: Fixed (was: Started)

Sign in to add a comment