Issue metadata
Sign in to add a comment
|
Random failures of webgl2_conformance_gl_tests on "Win10 Release (NVIDIA)" because PostSubBuffer fails |
||||||||||||||||||||||
Issue descriptionhttps://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20Release%20%28NVIDIA%29/?limit=200 The WebGL 2.0 conformance tests running with ANGLE's OpenGL backend started failing at least one test per run, randomly, in this build: https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20Release%20%28NVIDIA%29/4908 Last reliably green build: https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20Release%20%28NVIDIA%29/4907 The obvious culprit would be this one: Fix issue where some sites render at only 45fps in WebVR on Windows https://chromium-review.googlesource.com/899957 https://chromium.googlesource.com/chromium/src/+/593976ada0162683f152d1acaad33733044773ab Looking at the logs from any of the recent failures, like this one: https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20Release%20%28NVIDIA%29/4943 WebglConformance_conformance2_textures_svg_image_tex_3d_rg32f_rg_float in https://chromium-swarm.appspot.com/task?id=3b8e9ce76b082e10&refresh=10&show_raw=1 , the error is: [7824:3988:0208/062340.097:ERROR:gles2_cmd_decoder.cc(16156)] Context lost because SwapBuffers failed. [7824:3988:0208/062340.097:ERROR:gles2_cmd_decoder.cc(5604)] Error: 5 for Command kPostSubBufferCHROMIUM [7824:3988:0208/062340.097:ERROR:gpu_channel_manager.cc(200)] Exiting GPU process because some drivers cannot recover from problems. [6924:1028:0208/062340.103:ERROR:command_buffer_proxy_impl.cc(133)] ContextResult::kTransientFailure: Failed to send GpuChannelMsg_CreateCommandBuffer. [ which results in: AssertionError: Unable to fetch WebGL rendering context for Canvas FAIL Unable to fetch WebGL rendering context for Canvas Uncaught TypeError: Cannot read property 'RG' of null I'm not sure what's going on here, whether the renderer process is causing invalid texture IDs to be sent over to the GPU process, or ANGLE's GL backend is too-aggressively reporting errors. This bot needs to stay green so I'm trying a revert of the above CL. We should probably put webgl2_conformance_gl_tests on win_optional_gpu_tests_rel.
,
Feb 8 2018
+oetuaho as FYI
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28dcdcf5110246011a2a6488a44fa65ea7434190 commit 28dcdcf5110246011a2a6488a44fa65ea7434190 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Feb 08 18:10:05 2018 Revert "Fix issue where some sites render at only 45fps in WebVR on Windows" This reverts commit 593976ada0162683f152d1acaad33733044773ab. Reason for revert: caused webgl2_conformance_gl_tests to reliably fail on chromium.gpu.fyi. See http://crbug.com/810411 . Original change's description: > Fix issue where some sites render at only 45fps in WebVR on Windows > > The issue here is that we weren't recycling color buffers, and creation > of new buffers can be slow (in the order of 20ms) depending on color format. > > BUG= 798112 > > Change-Id: Ibecc5815f5386d13bc776cb85e2aee20756964d6 > Reviewed-on: https://chromium-review.googlesource.com/899957 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Brandon Jones <bajones@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534613} TBR=kbr@chromium.org,bajones@chromium.org,klausw@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 798112 , 810411 Change-Id: Ic55f7881706bbe66fb52d41fd32634d6da312bd5 Reviewed-on: https://chromium-review.googlesource.com/908948 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#535442} [modify] https://crrev.com/28dcdcf5110246011a2a6488a44fa65ea7434190/third_party/WebKit/Source/modules/vr/VRDisplay.cpp [modify] https://crrev.com/28dcdcf5110246011a2a6488a44fa65ea7434190/third_party/WebKit/Source/modules/vr/VRDisplay.h [modify] https://crrev.com/28dcdcf5110246011a2a6488a44fa65ea7434190/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp [modify] https://crrev.com/28dcdcf5110246011a2a6488a44fa65ea7434190/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h [modify] https://crrev.com/28dcdcf5110246011a2a6488a44fa65ea7434190/third_party/WebKit/Source/modules/xr/XRFrameProvider.cpp [modify] https://crrev.com/28dcdcf5110246011a2a6488a44fa65ea7434190/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp [modify] https://crrev.com/28dcdcf5110246011a2a6488a44fa65ea7434190/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h [modify] https://crrev.com/28dcdcf5110246011a2a6488a44fa65ea7434190/third_party/WebKit/Source/platform/graphics/gpu/XRFrameTransport.cpp [modify] https://crrev.com/28dcdcf5110246011a2a6488a44fa65ea7434190/third_party/WebKit/Source/platform/graphics/gpu/XRFrameTransport.h
,
Feb 8 2018
First build containing revert: https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20Release%20%28NVIDIA%29/4946 Let's see whether it's green.
,
Feb 8 2018
,
Feb 8 2018
This is also happening on Win10 Intel HD630 Release
,
Feb 8 2018
https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20Release%20%28NVIDIA%29/4946 still failed multiple tests: WebglConformance_conformance2_reading_format_r11f_g11f_b10f WebglConformance_conformance2_rendering_blitframebuffer_srgb_and_linear_drawbuffers WebglConformance_conformance2_textures_image_bitmap_from_canvas_tex_3d_rgba16f_rgba_half_float WebglConformance_conformance2_textures_image_data_tex_3d_rgba8_rgba_unsigned_byte WebglConformance_conformance2_textures_image_tex_3d_r11f_g11f_b10f_rgb_float Re-landing Bill's patch, because it clearly wasn't the cause. Geoff, can you please take this bug? It's surely affecting the ANGLE CQ. Again, this was the first failing build: https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20Release%20%28NVIDIA%29/4908
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0a174e7dcf9536cf55df68a73a936fcef57c5f5 commit f0a174e7dcf9536cf55df68a73a936fcef57c5f5 Author: Bill Orr <billorr@chromium.org> Date: Thu Feb 08 21:04:18 2018 Reland "Fix issue where some sites render at only 45fps in WebVR on Windows" This reverts commit 28dcdcf5110246011a2a6488a44fa65ea7434190. Reason for revert: This revert didn't fix the bots we were hoping it would fix. Original change's description: > Revert "Fix issue where some sites render at only 45fps in WebVR on Windows" > > This reverts commit 593976ada0162683f152d1acaad33733044773ab. > > Reason for revert: caused webgl2_conformance_gl_tests to reliably fail on chromium.gpu.fyi. See http://crbug.com/810411 . > > Original change's description: > > Fix issue where some sites render at only 45fps in WebVR on Windows > > > > The issue here is that we weren't recycling color buffers, and creation > > of new buffers can be slow (in the order of 20ms) depending on color format. > > > > BUG= 798112 > > > > Change-Id: Ibecc5815f5386d13bc776cb85e2aee20756964d6 > > Reviewed-on: https://chromium-review.googlesource.com/899957 > > Commit-Queue: Bill Orr <billorr@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Reviewed-by: Brandon Jones <bajones@chromium.org> > > Reviewed-by: Klaus Weidner <klausw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#534613} > > TBR=kbr@chromium.org,bajones@chromium.org,klausw@chromium.org,billorr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 798112 , 810411 > Change-Id: Ic55f7881706bbe66fb52d41fd32634d6da312bd5 > Reviewed-on: https://chromium-review.googlesource.com/908948 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535442} TBR=kbr@chromium.org,bajones@chromium.org,klausw@chromium.org,billorr@chromium.org Change-Id: If662a6b24faa6151487bae21b852de2b6b2741c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 798112 , 810411 Reviewed-on: https://chromium-review.googlesource.com/909748 Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#535512} [modify] https://crrev.com/f0a174e7dcf9536cf55df68a73a936fcef57c5f5/third_party/WebKit/Source/modules/vr/VRDisplay.cpp [modify] https://crrev.com/f0a174e7dcf9536cf55df68a73a936fcef57c5f5/third_party/WebKit/Source/modules/vr/VRDisplay.h [modify] https://crrev.com/f0a174e7dcf9536cf55df68a73a936fcef57c5f5/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp [modify] https://crrev.com/f0a174e7dcf9536cf55df68a73a936fcef57c5f5/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h [modify] https://crrev.com/f0a174e7dcf9536cf55df68a73a936fcef57c5f5/third_party/WebKit/Source/modules/xr/XRFrameProvider.cpp [modify] https://crrev.com/f0a174e7dcf9536cf55df68a73a936fcef57c5f5/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp [modify] https://crrev.com/f0a174e7dcf9536cf55df68a73a936fcef57c5f5/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h [modify] https://crrev.com/f0a174e7dcf9536cf55df68a73a936fcef57c5f5/third_party/WebKit/Source/platform/graphics/gpu/XRFrameTransport.cpp [modify] https://crrev.com/f0a174e7dcf9536cf55df68a73a936fcef57c5f5/third_party/WebKit/Source/platform/graphics/gpu/XRFrameTransport.h
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/617736404a624582a6ea2d68086824483ac21f5c commit 617736404a624582a6ea2d68086824483ac21f5c Author: Geoff Lang <geofflang@chromium.org> Date: Fri Feb 09 16:30:48 2018 Skip PostSubBuffer calls that have zero size. BUG= 810411 Change-Id: I8770b69fe4ab8a8f9bacd141c89e7f83f67f15fb Reviewed-on: https://chromium-review.googlesource.com/911589 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/617736404a624582a6ea2d68086824483ac21f5c/src/libANGLE/Surface.cpp [modify] https://crrev.com/617736404a624582a6ea2d68086824483ac21f5c/src/libANGLE/renderer/gl/wgl/DXGISwapChainWindowSurfaceWGL.cpp
,
Feb 9 2018
Removing WebVR per comment 8.
,
Feb 9 2018
Fixed the PostSubBuffer issue but another WebGL failure crept in, supression is landing now.
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba86133d91939a150c75e0ef64d896950884221d commit ba86133d91939a150c75e0ef64d896950884221d Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Feb 09 22:08:18 2018 Roll src/third_party/angle/ f8be756eb..617736404 (1 commit) https://chromium.googlesource.com/angle/angle.git/+log/f8be756eb976..617736404a62 $ git log f8be756eb..617736404 --date=short --no-merges --format='%ad %ae %s' 2018-02-09 geofflang Skip PostSubBuffer calls that have zero size. Created with: roll-dep src/third_party/angle BUG= 810411 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2c027996eeabbaffab9885923786ee39f43223d6 Reviewed-on: https://chromium-review.googlesource.com/911940 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#535846} [modify] https://crrev.com/ba86133d91939a150c75e0ef64d896950884221d/DEPS
,
Feb 10 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/c43611c02cd9f35148deeb057c033fa656b9b7ad commit c43611c02cd9f35148deeb057c033fa656b9b7ad Author: angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Feb 10 02:00:11 2018 Roll skia/third_party/externals/angle2/ 3e520b6f4..6108b766b (4 commits) https://chromium.googlesource.com/angle/angle.git/+log/3e520b6f4399..6108b766b371 $ git log 3e520b6f4..6108b766b --date=short --no-merges --format='%ad %ae %s' 2018-02-08 ynovikov Remove angle::Library and its usages 2018-02-09 thakis Prepare for -Wimplicit-fallthrough in ANGLE. 2018-02-09 geofflang Skip PostSubBuffer calls that have zero size. 2018-02-06 lucferron Vulkan: Implement blend states and add a simple test for it Created with: roll-dep skia/third_party/externals/angle2 BUG= 810411 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=bsalomon@google.com Change-Id: Ibc83785cb6e660ad5dd1f08c2a3543d07f0e28df Reviewed-on: https://skia-review.googlesource.com/106301 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> [modify] https://crrev.com/c43611c02cd9f35148deeb057c033fa656b9b7ad/DEPS
,
Feb 10 2018
,
Feb 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c0f91d898446ca8df9339c506ba632249e4ce63 commit 4c0f91d898446ca8df9339c506ba632249e4ce63 Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Feb 10 04:17:48 2018 Roll src/third_party/skia/ 308150821..0a5f99ccd (2 commits) https://skia.googlesource.com/skia.git/+log/308150821517..0a5f99ccdfa6 $ git log 308150821..0a5f99ccd --date=short --no-merges --format='%ad %ae %s' 2018-02-09 reed can't cheat on contains due to underflow 2018-02-09 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 3e520b6f4..6108b766b (4 commits) Created with: roll-dep src/third_party/skia BUG= 810411 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I30dd6ced4cc5d8519df8624b55b6a7171495e5d1 Reviewed-on: https://chromium-review.googlesource.com/912756 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#535952} [modify] https://crrev.com/4c0f91d898446ca8df9339c506ba632249e4ce63/DEPS
,
Feb 12 2018
PostSubBuffer failures are gone. Bot looks mostly green now. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbr@chromium.org
, Feb 8 2018