New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810397 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: ----



Sign in to add a comment

ServiceWorkerTest.TabsCreate flaky on Linux

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Feb 8 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of olka@google.com

Dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ServiceWorkerTestWithNativeBindings%2FServiceWorkerTest.TabsCreate%2F0&testType=browser_tests

Example:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-dbg/builds/4152

[ RUN      ] ServiceWorkerTestWithNativeBindings/ServiceWorkerTest.TabsCreate/0
[1014:1014:0208/064439.689874:WARNING:user_policy_manager_factory_chromeos.cc(184)] No policy loaded for known non-enterprise user
[1014:1014:0208/064439.737039:WARNING:user_session_manager.cc(1044)] Attempting to save user password for non enterprise user.
[1014:1014:0208/064440.164150:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[1014:1014:0208/064440.165247:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[1014:1014:0208/064440.167143:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[1014:1014:0208/064440.167491:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[1014:1014:0208/064440.366443:ERROR:wallpaper_controller.cc(1247)] User is ephemeral or guest! Fallback to default wallpaper.
[1:1:0208/064441.139828:ERROR:render_process_impl.cc(213)] WebFrame LEAKED 1 TIMES
[1014:1014:0208/064441.270302:WARNING:merge_session_throttling_utils.cc(142)] Loading content for a profile without session restore?
[1014:1034:0208/064441.304901:WARNING:simple_synchronous_entry.cc(1247)] Could not open platform files for entry.
[1014:1014:0208/064441.477545:INFO:CONSOLE(1)] "Uncaught TypeError: window.runServiceWorker is not a function", source:  (1)
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x7f163191b64d base::debug::StackTrace::StackTrace()
#1 0x7f1631919c7c base::debug::StackTrace::StackTrace()
#2 0x000006d46b54 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f161075bcb0 <unknown>
#4 0x7f16108236d3 epoll_wait
#5 0x7f1631c74331 epoll_dispatch
#6 0x7f1631c67925 event_base_loop
#7 0x7f16319c8a6d base::MessagePumpLibevent::Run()
#8 0x7f16319c2190 base::MessageLoop::Run()
#9 0x7f1631a78945 base::RunLoop::Run()
#10 0x000006df61f6 content::RunThisRunLoop()
#11 0x000006df79c8 content::MessageLoopRunner::Run()
#12 0x000006d51c48 content::DOMMessageQueue::WaitForMessage()
#13 0x000006d4dec1 content::(anonymous namespace)::ExecuteScriptHelper()
#14 0x000006d4cf31 content::ExecuteScriptAndExtractString()
#15 0x0000020d3190 extensions::ServiceWorkerTest_TabsCreate_Test::RunTestOnMainThread()
#16 0x000006d46697 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#17 0x0000009c5cad _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIP21RenderViewContextMenuJEEEvS4_OT_DpOT0_
#18 0x0000009c5bf4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#19 0x000006d48835 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#20 0x000006d4877c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#21 0x0000009a96bd _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#22 0x000005ca1ea9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#23 0x000005ca015c ChromeBrowserMainParts::PreMainMessageLoopRun()
#24 0x000002f7df54 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#25 0x7f16290252ec content::BrowserMainLoop::PreMainMessageLoopRun()
#26 0x7f1627ec709d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#27 0x7f1627ec6fe4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_
#28 0x7f162902c535 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#29 0x7f162902c47c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#30 0x7f1627dde05d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#31 0x7f1629dc3cfd content::StartupTaskRunner::RunAllTasksNow()
#32 0x7f16290207f0 content::BrowserMainLoop::CreateStartupTasks()
#33 0x7f162902e676 content::BrowserMainRunnerImpl::Initialize()
#34 0x7f1629018b01 content::BrowserMain()
#35 0x7f162aebc9b1 content::RunNamedProcessTypeMain()
#36 0x7f162aebf102 content::ContentMainRunnerImpl::Run()
#37 0x7f162aeb66b5 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#38 0x7f16245d4263 service_manager::Main()
#39 0x7f162aebb82b content::ContentMain()
#40 0x000006d46219 content::BrowserTestBase::SetUp()
#41 0x000005bad754 InProcessBrowserTest::SetUp()
#42 0x000001f7b84e ExtensionBrowserTest::SetUp()
#43 0x0000020e95fe extensions::ServiceWorkerTest::SetUp()
#44 0x0000009099ce _ZN7testing8internal12InvokeHelperIRKNSt3__16vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_
#45 0x000003982bc2 testing::internal::HandleExceptionsInMethodIfSupported<>()
#46 0x00000396d5e4 testing::Test::Run()
#47 0x00000396e01d testing::TestInfo::Run()
#48 0x00000396eacc testing::TestCase::Run()
#49 0x00000397a4dc testing::internal::UnitTestImpl::RunAllTests()
#50 0x00000398bcbe testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#51 0x000003984032 testing::internal::HandleExceptionsInMethodIfSupported<>()
#52 0x00000397a0e9 testing::UnitTest::Run()
#53 0x000005be5011 RUN_ALL_TESTS()
#54 0x000005be1f1b base::TestSuite::Run()
#55 0x000005b5597a ChromeTestSuiteRunner::RunTestSuite()
#56 0x000005b55a69 ChromeTestLauncherDelegate::RunTestSuite()
#57 0x000006de7a93 content::LaunchTests()
#58 0x000005b56daa LaunchChromeTests()
#59 0x000005b5531a main
#60 0x7f1610746f45 __libc_start_main
 

Comment 1 by olka@chromium.org, Feb 8 2018

 Issue 810396  has been merged into this issue.

Comment 2 by olka@chromium.org, Feb 8 2018

Summary: ServiceWorkerTest.TabsCreate flaky on Linux (was: ServiceWorkerTest.TabsCreate flaky in Linux)

Comment 3 by olka@chromium.org, Feb 8 2018

Disabling it.

Comment 4 by olka@chromium.org, Feb 8 2018

Labels: -Sheriff-Chromium
Owner: lazyboy@chromium.org
Status: Assigned (was: Available)
Disabling here https://chromium-review.googlesource.com/c/chromium/src/+/908754,
assigning to the owner.

Comment 5 by olka@chromium.org, Feb 8 2018

Labels: OS-Chrome OS-Linux

Comment 6 by olka@chromium.org, Feb 8 2018

Labels: Test-Disabled
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e13cd99eec541dada6a443abbd2dca4136d5772

commit 3e13cd99eec541dada6a443abbd2dca4136d5772
Author: Olga Sharonova <olka@chromium.org>
Date: Thu Feb 08 16:43:56 2018

Disabling ServiceWorkerTestWithNativeBindings/ServiceWorkerTest.TabsCreate on Linux

TBR=lazyboy@chromium.org

Bug:  810397 
Change-Id: Ia59ec231945d58b01e45ea3582aee92b96b81294
Reviewed-on: https://chromium-review.googlesource.com/908754
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535404}
[modify] https://crrev.com/3e13cd99eec541dada6a443abbd2dca4136d5772/chrome/browser/extensions/service_worker_apitest.cc

Note: This seems to be flakey on chromeos-linux also (and conveniently OS_LINUX disables for both).

We have also seen some flakiness on ServiceWorkerTestWithNativeBindings/ServiceWorkerTest.Events/0 there.

See  issue 810227  for more details.

ServiceWorkerTestWithNativeBindings/ServiceWorkerTest.Events/0 just failed again on linux-chromeos-dbg:

https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4158

Components: Blink>ServiceWorker
ServiceWorkerTestWithNativeBindings/ServiceWorkerTest.Events/0 is still flaky. Most recent failure: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/48114

(same stack as above in the bug)
Components: -Blink>ServiceWorker Platform>Apps>ServiceWorker
Cc: linds...@chromium.org
Labels: Hotlist-DisableReview
@lazyboy can you PTAL?
Status: Started (was: Assigned)
Will do.
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75ad1d95cb588f787a804ae21080beadeb054c7b

commit 75ad1d95cb588f787a804ae21080beadeb054c7b
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Thu Aug 30 05:16:54 2018

[Extension SW]: Fix race conditions in tests.

ServiceWorkerTest* had race conditions around promises that
set up workers to run tests. It was possible for those workers
to start replying (postMessage) to extension background script
before the script was ready to receive them. Fix this by running
the promise a bit later in time, after background script is set
up correctly.

This CL fixes a known flakiness: ServiceWorkerTest.TabsCreate
and enables the test.

In addition to that, this CL also fixes similar potential race
conditions, throughout extension service worker tests.

Bug:  810397 ,  810227 
Change-Id: I0ecbd0e915113ca12e37d33b5fae097ccfac76aa
Reviewed-on: https://chromium-review.googlesource.com/967412
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587449}
[modify] https://crrev.com/75ad1d95cb588f787a804ae21080beadeb054c7b/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/75ad1d95cb588f787a804ae21080beadeb054c7b/chrome/test/data/extensions/api_test/service_worker/events/page.js
[modify] https://crrev.com/75ad1d95cb588f787a804ae21080beadeb054c7b/chrome/test/data/extensions/api_test/service_worker/events_to_stopped_extension/page.js
[modify] https://crrev.com/75ad1d95cb588f787a804ae21080beadeb054c7b/chrome/test/data/extensions/api_test/service_worker/events_to_stopped_worker/page.js
[modify] https://crrev.com/75ad1d95cb588f787a804ae21080beadeb054c7b/chrome/test/data/extensions/api_test/service_worker/notifications/has_permission/page.js
[modify] https://crrev.com/75ad1d95cb588f787a804ae21080beadeb054c7b/chrome/test/data/extensions/api_test/service_worker/push_messaging/page.js
[modify] https://crrev.com/75ad1d95cb588f787a804ae21080beadeb054c7b/chrome/test/data/extensions/api_test/service_worker/sync/page.js
[modify] https://crrev.com/75ad1d95cb588f787a804ae21080beadeb054c7b/chrome/test/data/extensions/api_test/service_worker/tabs_create/page.js

Status: Fixed (was: Started)

Sign in to add a comment