Clean up gclient_config of perf |
||||
Issue descriptionIt seems to me that "perf" (https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/gclient_config.py?rcl=d69a3692a409ef0de70751cc9994d3a22ef6eb59&l=127) & "chromium_perf_android" (https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/gclient_config.py?rcl=d69a3692a409ef0de70751cc9994d3a22ef6eb59&l=142) configs are not obsolete. If so, we should clean them up Dave: can you verify this? If so, I can take this bug
,
Feb 8 2018
Marking as available since this seems to be triaged already.
,
Feb 8 2018
Yes, looks like desktop is using ['chromium_perf'] and android is using ['chromium_perf', 'android'] .
,
Feb 9 2018
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/4bb78765efbed63aea8b0f6340bc316477367ac5 commit 4bb78765efbed63aea8b0f6340bc316477367ac5 Author: nednguyen <nednguyen@google.com> Date: Mon Feb 12 14:57:09 2018 Remove 'chromium_perf_android' config This config is not used anywhere, so remove it Bug:810392 Change-Id: Id8cf83a39e23acba8759d63817b7aee9403036a3 Reviewed-on: https://chromium-review.googlesource.com/911588 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: David Tu <dtu@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/4bb78765efbed63aea8b0f6340bc316477367ac5/scripts/slave/README.recipes.md [modify] https://crrev.com/4bb78765efbed63aea8b0f6340bc316477367ac5/scripts/slave/recipe_modules/chromium/tests/gclient.py [modify] https://crrev.com/4bb78765efbed63aea8b0f6340bc316477367ac5/scripts/slave/recipe_modules/chromium/gclient_config.py
,
Feb 14 2018
Looks like "perf" still used by legacy bisect. So I will just call this a day |
||||
►
Sign in to add a comment |
||||
Comment 1 by nednguyen@chromium.org
, Feb 8 2018